Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Skeleton not showing animation #33076

Closed
2 tasks done
nicoleweese opened this issue Oct 17, 2024 · 2 comments
Closed
2 tasks done

[Bug]: Skeleton not showing animation #33076

nicoleweese opened this issue Oct 17, 2024 · 2 comments

Comments

@nicoleweese
Copy link

Component

Skeleton

Package version

9.54.13

React version

18.3.1

Environment

System:
OS: Windows 11 10.0.22631
CPU: (16) x64 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Memory: 42.93 GB / 63.95 GB
Browsers:
Edge: Chromium (129.0.2792.65)
Internet Explorer: 11.0.22621.3527

Current Behavior

return ( <div className={classNames.essentialsItem}> <div className={mergeClasses(classNames.essentialsNoWrap, classNames.essentialsLabel)}>{label}</div> <div className={mergeClasses(classNames.essentialsNoWrap, classNames.essentialsDivider)}>:</div> <div aria-busy={!value} aria-label={${labelAria} ${valueAria}} className={mergeClasses(classNames.essentialsNoWrap, classNames.essentialsValueContainer)} > {!value ? ( // TODO: is not "shimmering" <Skeleton animation="wave"> <SkeletonItem animation="wave" /> </Skeleton> ) : ( FieldValueContent )} </div> </div> );

When loading the SkeletonItem, I don't see any wave or pulse regardless of whether I specify animation or not. Even when rendering the Skeleton without allowing it to update to actual content, the animations never show up.

Expected Behavior

I am expecting the wave animation to show by default, and the pulse animation to show when specified.

Reproduction

https://stackblitz.com/edit/cieedh?file=src%2Fexample.tsx

Steps to reproduce

I don't see it reproducing in stackblitz.

Are you reporting an Accessibility issue?

no

Suggested severity

High - No workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@WanderG
Copy link

WanderG commented Oct 18, 2024

Did you check if animations are enabled in your windows settings? (Accessibility => Visual effects => Animation effects)

@nicoleweese
Copy link
Author

nicoleweese commented Oct 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants