Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scale] Migrate to new variant structure #33112

Open
robertpenner opened this issue Oct 22, 2024 · 2 comments · May be fixed by #33341
Open

[Scale] Migrate to new variant structure #33112

robertpenner opened this issue Oct 22, 2024 · 2 comments · May be fixed by #33341
Assignees
@robertpenner @pixel-perfectionist
Labels
Status: In PR

Comments

@robertpenner
Copy link
Collaborator

robertpenner commented Oct 22, 2024 •
edited
Loading

Follow the changes for Fade in 33081.

NOTE: We are not including Scale in the motion components beta release. It needs more design and API work.
@robertpenner robertpenner mentioned this issue Oct 22, 2024
Open
3 tasks
@pixel-perfectionist
Copy link
Member

https://github.com/microsoft/fluentui/blob/48aaf290109e36e4c7282855a5bd4b86feedad38/packages/react-components/react-motion-components-preview/library/src/components/Scale/Scale.ts - made update with migration to new variant structure. I would like to review with Robert before move forward.

@robertpenner robertpenner self-assigned this Nov 25, 2024
@robertpenner
Copy link
Collaborator Author

https://github.com/microsoft/fluentui/blob/48aaf290109e36e4c7282855a5bd4b86feedad38/packages/react-components/react-motion-components-preview/library/src/components/Scale/Scale.ts - made update with migration to new variant structure. I would like to review with Robert before move forward.

Thanks Alex, I'll review this and check back in with you.

@pixel-perfectionist pixel-perfectionist linked a pull request Nov 25, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertpenner robertpenner

@pixel-perfectionist pixel-perfectionist

Labels
Status: In PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(motion): Refactor scale, migrate to new variant structure pixel-perfectionist/fluentui
2 participants
@robertpenner @pixel-perfectionist