font sizes defined in px instead of rem

[jligeza]

Having font sizes for tokens/components defined in px instead of rem hurts accessibility, because it makes them unaffected by web browser global font size setting.

It would be better to have them and line heights converted to rem.

fluentui/packages/tokens/src/global/fonts.ts

Line 3 in b59061d

export const fontSizes: FontSizeTokens = {

[layershifter]

That's the intentional decision to go with pixels over rem units.

I don't recall if there is a RFC about it, but it was discussed multiple times in offline and it was decided to use pixels for Fluent UI over other units.

[jligeza]

That's the intentional decision to go with pixels over rem units.

I don't recall if there is a RFC about it, but it was discussed multiple times in offline and it was decided to use pixels for Fluent UI over other units.

I am curious why you decided not to go with rem, which is needed for optimal accessibility. Could you explain?