From f7e71ddfd36c04f17fb2ba425b958e3b8921dbab Mon Sep 17 00:00:00 2001 From: Andrew Omondi Date: Mon, 28 Oct 2024 09:56:08 +0300 Subject: [PATCH] updates version and release notes removes duplicate tests --- CHANGELOG.md | 6 ++++++ Directory.Build.props | 2 +- .../DeserializationHelpersTests.NonGeneric.cs | 20 ------------------- 3 files changed, 7 insertions(+), 21 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 97f7ede..a52b7fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [1.13.2] - 2024-10-28 + +### Changed + +- Added Non-Generic Solution to KiotaDeserialization helper method. [#436](https://github.com/microsoft/kiota-dotnet/pull/436) + ## [1.13.1] - 2024-10-10 ### Changed diff --git a/Directory.Build.props b/Directory.Build.props index bfec8f6..9988389 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,7 +1,7 @@ - 1.13.1 + 1.13.2 false diff --git a/tests/abstractions/Serialization/DeserializationHelpersTests.NonGeneric.cs b/tests/abstractions/Serialization/DeserializationHelpersTests.NonGeneric.cs index bab53f0..c2251d8 100644 --- a/tests/abstractions/Serialization/DeserializationHelpersTests.NonGeneric.cs +++ b/tests/abstractions/Serialization/DeserializationHelpersTests.NonGeneric.cs @@ -29,26 +29,6 @@ public async Task DeserializesObjectUntypedWithoutReflectionAsync() Assert.Equal("123", result.Id); } - [Fact] - public async Task DeserializesObjectUntypedWithReflectionAsync() - { - var strValue = "{'id':'123'}"; - var mockParseNode = new Mock(); - mockParseNode.Setup(x => x.GetObjectValue(It.IsAny>())).Returns(new TestEntity() - { - Id = "123" - }); - var mockJsonParseNodeFactory = new Mock(); - mockJsonParseNodeFactory.Setup(x => x.GetRootParseNodeAsync(It.IsAny(), It.IsAny(), It.IsAny())).Returns(Task.FromResult(mockParseNode.Object)); - mockJsonParseNodeFactory.Setup(x => x.ValidContentType).Returns(_jsonContentType); - ParseNodeFactoryRegistry.DefaultInstance.ContentTypeAssociatedFactories[_jsonContentType] = mockJsonParseNodeFactory.Object; - - var result = (TestEntity?)await KiotaSerializer.DeserializeAsync(typeof(TestEntity), _jsonContentType, strValue); - - Assert.NotNull(result); - Assert.Equal("123", result.Id); - } - [Fact] public async Task DeserializesCollectionOfObjectUntypedAsync() {