Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for std uri template 2 and date time drop #395

Closed
baywet opened this issue Sep 24, 2024 · 1 comment · Fixed by #399
Closed

prepare for std uri template 2 and date time drop #395

baywet opened this issue Sep 24, 2024 · 1 comment · Fixed by #399
Assignees
Labels
enhancement New feature or request WIP

Comments

@baywet
Copy link
Member

baywet commented Sep 24, 2024

related std-uritemplate/std-uritemplate-csharp#11
The following types need to the normalized to their RFC3339 representation before they are passed to std URI template when they are present are query or path parameter values
DateTime, DateTimeOffset, and their collection representations (array, enumerable)

@baywet baywet added the enhancement New feature or request label Sep 24, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Sep 24, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Sep 24, 2024
@andrueastman
Copy link
Member

andrueastman commented Oct 1, 2024

I believe this is already handled in the library.

The request info class looks to handle the types already here

DateTimeOffset dateTimeOffset => dateTimeOffset.ToString("o"),// Default to ISO 8601 for datetimeoffsets in the url.

Furthermore, validation checks are passing as the tests below are part of the suite.

@baywet baywet linked a pull request Oct 1, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Oct 1, 2024
@andrueastman andrueastman self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants