Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure 3XX responses without location header do not throw #272

Open
baywet opened this issue Mar 21, 2024 · 1 comment · May be fixed by #498
Open

ensure 3XX responses without location header do not throw #272

baywet opened this issue Mar 21, 2024 · 1 comment · May be fixed by #498
Assignees
@baywet
Labels
area:http help wanted Standard GitHub label WIP

Comments

@baywet
Copy link
Member

baywet commented Mar 21, 2024

follow up to microsoft/kiota#4367
and microsoft/kiota#4190

Implement a unit test with a 304 response, no location header, check the request adapter returns null and doesn't throw.
Most likely this line will need to be adapted.
https://github.com/microsoft/kiota-http-dotnet/blob/d960c5fa7f0661ea294b6962be105890a27fe999/src/HttpClientRequestAdapter.cs#L385
@baywet baywet added the Standard GitHub label Issue caused by core project dependency modules or library label Mar 21, 2024
@andrueastman andrueastman mentioned this issue Apr 3, 2024
Merged
@andrueastman
Copy link
Member

Transferring issue as part of #238

@andrueastman andrueastman transferred this issue from microsoft/kiota-http-dotnet Jul 9, 2024
@andrueastman andrueastman added help wanted Standard GitHub label area:http and removed Standard GitHub label Issue caused by core project dependency modules or library labels Jul 9, 2024
@baywet baywet self-assigned this Dec 18, 2024
@baywet baywet moved this from New📃 to In Progress 🚧 in Kiota Dec 18, 2024
@baywet baywet linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
area:http help wanted Standard GitHub label WIP
Projects
Kiota
Status: In Progress 🚧
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/redirect with no location microsoft/kiota-dotnet
2 participants
@andrueastman @baywet