Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving serialization #311

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Improving serialization #311

merged 12 commits into from
Aug 20, 2024

Conversation

svrooij
Copy link
Contributor

@svrooij svrooij commented Jul 31, 2024

Fixed #310

@svrooij svrooij requested a review from a team as a code owner July 31, 2024 13:41
baywet
baywet requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the work here.

src/abstractions/serialization/KiotaJsonSerializer.Serialization.cs Outdated Show resolved Hide resolved
src/abstractions/serialization/KiotaJsonSerializer.Serialization.cs Outdated Show resolved Hide resolved
src/abstractions/serialization/KiotaSerializer.Serialization.cs Outdated Show resolved Hide resolved
@svrooij
Copy link
Contributor Author

svrooij commented Aug 1, 2024

It was a bit of pickle, but I think this is a pretty nice solution. Did I just notice that the backing store stuff if not referenced in any tests?

svrooij added 2 commits August 3, 2024 18:51
@svrooij
Moved extension methods to their respective projects
e699007 
This way you have to include these packages as well, they will throw otherwise.
@svrooij
Adding test that emulate new extension methods
b28d524
@svrooij
Copy link
Contributor Author

svrooij commented Aug 5, 2024

I'm out of the office this week, and see that the formatting failed.

I checked the box that I gave the contributors access to the branch. So if anybody wants to run dotnet format on my code, please do 🤩

Andrew Omondi and others added 2 commits August 5, 2024 11:59
@svrooij svrooij mentioned this pull request Aug 19, 2024
Closed
baywet
baywet previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!
@andrueastman for final review and merge.
I believe we'll need a version bump/changelog entry as well.

baywet
baywet previously approved these changes Aug 19, 2024
View reviewed changes
@andrueastman andrueastman enabled auto-merge August 20, 2024 13:34
andrueastman
andrueastman approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @svrooij

@andrueastman andrueastman merged commit a60e99c into microsoft:main Aug 20, 2024
7 checks passed
@andrueastman andrueastman mentioned this pull request Aug 27, 2024
Closed
This was referenced Sep 3, 2024
Closed
Merged
@baywet baywet mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: Use Kiota generated models for serialization
3 participants
@svrooij @andrueastman @baywet