Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the WinUI logo #10189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating the WinUI logo #10189

wants to merge 1 commit into from
+54 −41

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Nov 20, 2024 •
edited
Loading

As part of our design refresh, we've updated the WinUI logo. This PR updates the images we use in the readme.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Nov 20, 2024
@niels9001 niels9001 changed the title Updating icons Updating the WinUI logo Nov 20, 2024
michael-hawker
michael-hawker approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@michael-hawker michael-hawker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉🎉

@Lamparter
Copy link

Can I just add that these images look amazing 🎉
Won't the opengraph repository image also need to be updated?

@niels9001
Copy link
Contributor Author

Can I just add that these images look amazing 🎉 Won't the opengraph repository image also need to be updated?

Oh yes, for sure! Can you point me to the places where things need to be updated?

@Lamparter
Copy link

Oh yes, for sure! Can you point me to the places where things need to be updated?

What about the image that ships in the visual studio sdk? I wouldn't know where to find it, and since the image is a bit different from the other ones (sort of flat) it might not fit very well to include the image submitted here.

image
^ this in visual studio

@ghost1372
Copy link
Contributor

Oh yes, for sure! Can you point me to the places where things need to be updated?

What about the image that ships in the visual studio sdk? I wouldn't know where to find it, and since the image is a bit different from the other ones (sort of flat) it might not fit very well to include the image submitted here.

image ^ this in visual studio

https://github.com/microsoft/WindowsAppSDK/tree/main/dev/VSIX

@Lamparter
Copy link

Amazing!

@Lamparter Lamparter mentioned this pull request Nov 28, 2024
Closed
@niels9001
Copy link
Contributor Author

Oh yes, for sure! Can you point me to the places where things need to be updated?

What about the image that ships in the visual studio sdk? I wouldn't know where to find it, and since the image is a bit different from the other ones (sort of flat) it might not fit very well to include the image submitted here.

image ^ this in visual studio

See: microsoft/WindowsAppSDK#4924

@dotMorten
Copy link
Contributor

My $0.02: Looks a bit odd that it is now a cube with rounded corners, except the corner in the center isn't rounded. Also feels like it's deemphasizing the < > markup hint by moving them to the center and reducing contrast. Oh well :)

@dotMorten
Copy link
Contributor

The new msbuild logo gets the rounded corner right: https://aka.ms/msbuildicon
2a5bcfab-c533-4c36-8f2c-02da81ed850a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@duncanmacmichael duncanmacmichael duncanmacmichael approved these changes

Assignees
No one assigned
Labels
needs-triage Issue needs to be triaged by the area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@niels9001 @Lamparter @ghost1372 @dotMorten @duncanmacmichael @michael-hawker