Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROCm support #213

Merged
merged 49 commits into from
Nov 24, 2023
Merged

ROCm support #213

merged 49 commits into from
Nov 24, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Nov 8, 2023

No description provided.

@chhwang chhwang marked this pull request as ready for review November 9, 2023 14:54
@chhwang chhwang marked this pull request as draft November 10, 2023 04:21
@chhwang chhwang marked this pull request as ready for review November 21, 2023 06:27
@chhwang chhwang requested review from whchung and yzygitzh and removed request for whchung November 23, 2023 00:43
chhwang
chhwang commented Nov 23, 2023
View reviewed changes
include/mscclpp/device.hpp Outdated Show resolved Hide resolved
cp5555
cp5555 reviewed Nov 24, 2023
View reviewed changes
test/allgather_test_cpp.cu Outdated Show resolved Hide resolved
@chhwang chhwang merged commit 544ff0c into main Nov 24, 2023
12 of 15 checks passed
@chhwang chhwang deleted the chhwang/rocm branch November 24, 2023 08:41
@chhwang chhwang mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzygitzh yzygitzh yzygitzh approved these changes

@cp5555 cp5555 cp5555 approved these changes

@saeedmaleki saeedmaleki Awaiting requested review from saeedmaleki

@Binyang2014 Binyang2014 Awaiting requested review from Binyang2014

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chhwang @cp5555 @yzygitzh @Binyang2014