Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to compile on Linux / Clang 16.0.6 #596

Open
haecker-felix opened this issue Aug 22, 2023 · 2 comments
Open

[BUG] Unable to compile on Linux / Clang 16.0.6 #596

haecker-felix opened this issue Aug 22, 2023 · 2 comments
Labels
Area-MSIX SDK This issue is related to msix.dll Bug Something isn't working

Comments

@haecker-felix
Copy link

Command: ./makelinux.sh

[ 94%] Building CXX object src/msix/CMakeFiles/msix.dir/common/MSIXResource.cpp.o
[ 95%] Building CXX object src/msix/CMakeFiles/msix.dir/common/Log.cpp.o
[ 95%] Building CXX object src/msix/CMakeFiles/msix.dir/common/UnicodeConversion.cpp.o
[ 95%] Building CXX object src/msix/CMakeFiles/msix.dir/common/Encoding.cpp.o
In file included from /var/home/haecker-felix/Downloads/msix-packaging-MSIX-Core-1.2-release/src/msix/common/Encoding.cpp:11:
/var/home/haecker-felix/Downloads/msix-packaging-MSIX-Core-1.2-release/src/inc/internal/Encoding.hpp:14:50: error: use of undeclared identifier 'uint8_t'
    std::string Base32Encoding(const std::vector<uint8_t>& bytes);
                                                 ^
/var/home/haecker-felix/Downloads/msix-packaging-MSIX-Core-1.2-release/src/inc/internal/Encoding.hpp:15:22: error: no member named 'uint8_t' in namespace 'std'
    std::vector<std::uint8_t> GetBase64DecodedValue(const std::string& value);
                ~~~~~^
2 errors generated.
make[2]: *** [src/msix/CMakeFiles/msix.dir/build.make:146: src/msix/CMakeFiles/msix.dir/common/Encoding.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:567: src/msix/CMakeFiles/msix.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
clang version 16.0.6 (Fedora 16.0.6-2.fc38)
Target: x86_64-redhat-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue needs to be triaged by a member of the core team label Aug 22, 2023
@anarvekar-msft anarvekar-msft added Bug Something isn't working Area-MSIX SDK This issue is related to msix.dll and removed Needs-Triage Issue needs to be triaged by a member of the core team labels Sep 18, 2023
@anarvekar-msft
Copy link
Contributor

Thank you for your comment- this is a duplicate of #514

@josuegomes
Copy link

Thank you for your comment- this is a duplicate of #514

No, it's not. This error occurs even with ./makelinux.sh --skip-tests.

This patch fixes the build:

diff --git a/src/inc/internal/Encoding.hpp b/src/inc/internal/Encoding.hpp
index c647567e..dcc42f47 100644
--- a/src/inc/internal/Encoding.hpp
+++ b/src/inc/internal/Encoding.hpp
@@ -5,6 +5,7 @@
 #pragma once
 
 #include <string>
+#include <cstdint>^M
 
 namespace MSIX { namespace Encoding {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-MSIX SDK This issue is related to msix.dll Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants