You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Commit d375318 changed cmake_minimum_required to 3.29.0, but I do not see any technical reason for this specific value to have been chosen and it breaks building on systems like Debian stable which is still at 3.25.1, for example.
I can manually change the cmake_minimum_required to 3.25 and build using makeLinux.sh and get working binaries without any issues. The cmake_minimum_required should be the actual minimum required version, not necessarily the version your CI pipeline happens to be using, at least if you intend for others to be able to clone the repo and build it on their systems too.
Yes, it's trivial to just change the value across all the CMakeLists.txt files myself and alternatively there actually is a CMake 3.29 package in Debian stable-backports if it ever really become necessary, but it seems strange to break people's builds that were previously working when it isn't actually necessary.
The text was updated successfully, but these errors were encountered:
Project
MSIX SDK
Describe the bug
Commit d375318 changed
cmake_minimum_required
to 3.29.0, but I do not see any technical reason for this specific value to have been chosen and it breaks building on systems like Debian stable which is still at 3.25.1, for example.I can manually change the
cmake_minimum_required
to 3.25 and build usingmakeLinux.sh
and get working binaries without any issues. Thecmake_minimum_required
should be the actual minimum required version, not necessarily the version your CI pipeline happens to be using, at least if you intend for others to be able to clone the repo and build it on their systems too.Yes, it's trivial to just change the value across all the CMakeLists.txt files myself and alternatively there actually is a CMake 3.29 package in Debian stable-backports if it ever really become necessary, but it seems strange to break people's builds that were previously working when it isn't actually necessary.
The text was updated successfully, but these errors were encountered: