Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cmake_minimum_required should be set to a more reasonable value #629

Open
nephatrine opened this issue May 10, 2024 · 0 comments
Open
Labels
Needs-Triage Issue needs to be triaged by a member of the core team

Comments

@nephatrine
Copy link

Project
MSIX SDK

Describe the bug
Commit d375318 changed cmake_minimum_required to 3.29.0, but I do not see any technical reason for this specific value to have been chosen and it breaks building on systems like Debian stable which is still at 3.25.1, for example.

I can manually change the cmake_minimum_required to 3.25 and build using makeLinux.sh and get working binaries without any issues. The cmake_minimum_required should be the actual minimum required version, not necessarily the version your CI pipeline happens to be using, at least if you intend for others to be able to clone the repo and build it on their systems too.

Yes, it's trivial to just change the value across all the CMakeLists.txt files myself and alternatively there actually is a CMake 3.29 package in Debian stable-backports if it ever really become necessary, but it seems strange to break people's builds that were previously working when it isn't actually necessary.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue needs to be triaged by a member of the core team label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Triage Issue needs to be triaged by a member of the core team
Projects
None yet
Development

No branches or pull requests

1 participant