Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add gBeforeEndOfDxeEventGuid, gAfterEndOfDxeEventGuid and gDispatchDeferredImagesEventGuid and signal it in PlatformBootManagerLib #570

Closed
MarcChen46 opened this issue Sep 3, 2024 · 3 comments
Labels
state:under-discussion Under discussion type:feature-request A new feature proposal urgency:medium Important with a moderate impact

Comments

@MarcChen46
Copy link
Contributor

MarcChen46 commented Sep 3, 2024

Feature Overview

Due to there are some requirement that we need to invoke some specific functions in some flow that has sequence requirement, we would like to add gBeforeEndOfDxeEventGroupGuid, gAfterEndOfDxeEventGroupGuid and gDispatchDeferredImagesEventGroupGuid.

The gBeforeEndOfDxeEventGroupGuid and gAfterEndOfDxeEventGroupGuid will be signaled in ExitPmAuth() that before and after gEfiEndOfDxeEventGroupGuid.

The gDispatchDeferredImagesEventGroupGuid will be signaled in PlatformBootManagerBeforeConsole() after EfiBootManagerDispatchDeferredImages

Solution Overview

  • Add gBeforeEndOfDxeEventGuid, gAfterEndOfDxeEventGuid and gDispatchDeferredImagesEventGuid to MsCorePkg.dec

  • The gBeforeEndOfDxeEventGroupGuid and gAfterEndOfDxeEventGroupGuid will be signaled in ExitPmAuth() that before and after gEfiEndOfDxeEventGroupGuid.

  • The gDispatchDeferredImagesEventGroupGuid will be signaled in PlatformBootManagerBeforeConsole() after EfiBootManagerDispatchDeferredImages

Alternatives Considered

No response

Urgency

Medium

Are you going to implement the feature request?

I will implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

No response

@MarcChen46 MarcChen46 added state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal labels Sep 3, 2024
@github-actions github-actions bot added state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps urgency:medium Important with a moderate impact labels Sep 3, 2024
@MarcChen46
Copy link
Contributor Author

@apop5, please take a look if this proposal is ok to you, then I will find someone to create PR for this proposal, thanks.

@apop5
Copy link
Contributor

apop5 commented Sep 4, 2024

Would it be possible to take this to EDK2 first? Bds is already very fragmented, with each silicon vendor providing their own library instances that implement this additional checks. If EDK2 can align on a common implementation, it would greatly simplify the maintenance, and it could allow silicon vendors to be able to use stock edk2.

@apop5 apop5 added state:under-discussion Under discussion and removed state:needs-triage Needs to triaged to determine next steps state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps labels Sep 4, 2024
@MarcChen46
Copy link
Contributor Author

after offline discussion, agree to work with silicon vendor to upstream to edk2, close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:under-discussion Under discussion type:feature-request A new feature proposal urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

2 participants