Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AdvLoggerPkg: Build Arm modules and clean up BaseArm/AdvancedLoggerLib #586

Closed
1 task done
makubacki opened this issue Sep 27, 2024 · 0 comments · Fixed by #591
Closed
1 task done

[Bug]: AdvLoggerPkg: Build Arm modules and clean up BaseArm/AdvancedLoggerLib #586

makubacki opened this issue Sep 27, 2024 · 0 comments · Fixed by #591
Assignees
Labels
type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@makubacki
Copy link
Member

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Arm related support has had a few bugs/points of confusion recently identified.

  1. ARM and AARCH64 code exists in the package but AdvLoggerPkg.dsc does not list those as SUPPORTED_ARCHITECTURES.
  2. AdvLoggerPkg/Library/AdvancedLoggerLib/BaseArm/AdvancedLoggerLib.inf lists the following as valid architectures but the library instance only claims to support "Arm" otherwise (in the BaseArm directory). Should this only be AARCH64 for clarity?
#
#  VALID_ARCHITECTURES           = IA32 X64 AARCH64
#
  1. The MODULE_TYPE is BASE, but the library claims to be a MM_STANDALONE instance of the AdvancedLoggerLib library class. The MODULE_TYPE being BASE and it only applying to MM_STANDALONE is not a problem. However, it if truly does only apply to MM_STANDALONE, it should apply that module type restriction in the LIBRARY_CLASS value. For example:
  LIBRARY_CLASS                  = AdvancedLoggerLib | MM_STANDALONE

Expected Behavior

Library is consistent, builds, and documented accurately.

Steps To Reproduce

N/A

Build Environment

N/A

Version Information

Tag: [v2024050001.0.0](https://github.com/microsoft/mu_plus/releases/tag/v2024050001.0.0)

Urgency

Medium

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@makubacki makubacki added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps labels Sep 27, 2024
@github-actions github-actions bot added state:needs-owner Needs an issue owner to be assigned urgency:medium Important with a moderate impact labels Sep 27, 2024
@makubacki makubacki changed the title [Bug]: <title> [Bug]: AdvLoggerPkg: Build Arm modules and clean up BaseArm/AdvancedLoggerLib Sep 27, 2024
@makubacki makubacki removed the state:needs-triage Needs to triaged to determine next steps label Sep 27, 2024
@github-actions github-actions bot removed the state:needs-owner Needs an issue owner to be assigned label Sep 27, 2024
@os-d os-d linked a pull request Sep 30, 2024 that will close this issue
5 tasks
@os-d os-d closed this as completed in #591 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants