Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add size reporting to the platforms in the repo #758

Closed
makubacki opened this issue Nov 2, 2023 · 2 comments
Closed

[Feature]: Add size reporting to the platforms in the repo #758

makubacki opened this issue Nov 2, 2023 · 2 comments
Labels
complexity:intermediate Requires intermediate background information and effort to accomplish state:help-wanted Extra attention (collaborator) is needed state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:feature-request A new feature proposal urgency:low Little to no impact

Comments

@makubacki
Copy link
Member

Feature Overview

Project Mu code is integrated into various platforms. Flash space is a key platform constraint.

Since this repo reflects the integration work that would be expected of platforms integrating upstream Mu changes, it would be helpful to add size tracking to the repository.

Solution Overview

  1. When an incoming Mu submodule introduces a new library/component, ensure it is integrated in Mu Tiano Platforms. Or, that incoming changes are already being used by a platform in Mu Tiano Platforms.
  2. Check the overall size difference between each module before and after the change. For example, state the size increase in the PR due to an incoming change.
  3. Reviewers should note the size increase and for large increases, determine if there's a change in the upstream repo that can reduce the overall size impact. If so, file an issue in that repo describing the total increase and the suggestion to reduce size.

Alternatives Considered

No response

Urgency

Low

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@makubacki makubacki added complexity:intermediate Requires intermediate background information and effort to accomplish state:needs-triage Needs to triaged to determine next steps state:help-wanted Extra attention (collaborator) is needed type:feature-request A new feature proposal labels Nov 2, 2023
@github-actions github-actions bot added state:needs-owner Needs an issue owner to be assigned urgency:low Little to no impact labels Nov 2, 2023
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Dec 17, 2023
Copy link

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:intermediate Requires intermediate background information and effort to accomplish state:help-wanted Extra attention (collaborator) is needed state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:feature-request A new feature proposal urgency:low Little to no impact
Projects
None yet
Development

No branches or pull requests

1 participant