Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore DeviceSecurity Functionality #275

Closed
1 task done
makubacki opened this issue May 30, 2024 · 1 comment · Fixed by #276
Closed
1 task done

Restore DeviceSecurity Functionality #275

makubacki opened this issue May 30, 2024 · 1 comment · Fixed by #276
Assignees
Labels
urgency:medium Important with a moderate impact

Comments

@makubacki
Copy link
Member

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

The DeviceSecurity code in SecurityPkg was intentionally removed in #272 and the libspdm submodule removed from the repo because it used an unreliable host (cryptomilk) for the cmocka submodule.

This means that currently the DeviceSecurity code is not built and the libspdm submodule in SecurityPkg is not available as expected.

Expected Behavior

That commit from that PR should be reverted to restore previous behavior when the host has been updated in libspdm, edk2 has updated the libspdm submodule, and that change can be cherry-picked back to SecurityPkg in Mu Tiano Plus.

Steps To Reproduce

View the changes in commit 11506d5 that resulted from PR 272.

Build Environment

All

Version Information

Commit: 11506d59b72515a8d561baddfa2bb6660924ad6e

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@github-actions github-actions bot added urgency:medium Important with a moderate impact labels May 30, 2024
@makubacki
Copy link
Member Author

All upstream changes are done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgency:medium Important with a moderate impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant