Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Adding TopK: docs/operators.md pre-commit hook failed #298

Open
J3698 opened this issue May 21, 2021 · 2 comments
Open

Adding TopK: docs/operators.md pre-commit hook failed #298

J3698 opened this issue May 21, 2021 · 2 comments

Comments

@J3698
Copy link

J3698 commented May 21, 2021

I would like to add TopK at least for CPU. Unfortunately, I am getting the following error upon committing:

ERR! pre-commit File(s) not formatted:
ERR! pre-commit docs/operators.md

It looks like that file is autogenerated, should I just bypass that hook? Thanks!

@xzhu1900
Copy link
Contributor

Hi J3698,

Yes, operators.md is autogenerated. When a new change is made to the operator set, we need to also update this file. You can try adding that file and committing again. That should be able to resolve this error.

@J3698
Copy link
Author

J3698 commented May 22, 2021

Thanks, that worked! I didn't realize it would require two commits. I'm wondering, would it be useful for me to add a message on failure that you can try again? Then new contributors like myself will know that something changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants