Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

TopK-1 CPU unittests #299

Open
J3698 opened this issue May 22, 2021 · 1 comment
Open

TopK-1 CPU unittests #299

J3698 opened this issue May 22, 2021 · 1 comment

Comments

@J3698
Copy link

J3698 commented May 22, 2021

I am almost done implementing CPU TopK-1 and am passing the op tests I wrote. However it takes quite a while to write the unit tests, and I feel even if I spent another hour writing tests, I could be missing something.

So I'm thinking I should also write some additional randomized test cases in the folder unittest/cpu (which does not exist). I think this would be more exhaustive and take less time to write more tests. If this sounds okay I will start on it in a few days.

If it is also okay, I'd like to add an option to run one unit test at a time. I would change npm test unittest to npm test unittests, and add an npm test unittest [test], which only runs one unit test. If that is okay, I will also get started on that in the next couple of days.

Thanks!

@J3698 J3698 mentioned this issue May 26, 2021
@fs-eire
Copy link
Contributor

fs-eire commented Sep 10, 2021

Thanks for your contribution! Sorry for the late reply.

we are currently doing a different approach to support CPU kernels in browser. We compiles ONNX Runtime as a whole so that we can have a full CPU kernel coverage. ONNX Runtime Web offers enhanced user experience and improved performance. Please visit ONNX Runtime Web to get more details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants