Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a card to "Download to Drive" #6264

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kiki-lee
Copy link
Contributor

@kiki-lee kiki-lee commented Dec 7, 2023

Stashing this here until we're ready to add. @Jaqster would like more data before we merge.

We have received feedback that people don't know how to save projects other than sharing or uploading to GitHub. In part, this could be because the save button is touching the name field, so it looks like it's meant to save name changes:
Screenshot 2023-12-07 at 12 04 19 PM


Also, the save button goes away when you're working in a tutorial:
Screenshot 2023-12-07 at 12 10 42 PM


Or a GitHub repo:
Screenshot 2023-12-07 at 12 09 14 PM


The clever educator/student will notice that there's a Download button, which seems like the natural place to go when looking to download your project...but when they click, they're faced with these options, none of which are "Download to Drive".
Screenshot 2023-12-07 at 12 09 32 PM


Those of us who work here know that we could choose any of these to save our projects to drive, but there's no way for anyone else to know this is the case. My solution is to add a card for downloading to your machine.
Screenshot 2023-12-07 at 12 03 34 PM

@kiki-lee kiki-lee marked this pull request as draft December 7, 2023 20:18
@Jaqster
Copy link
Member

Jaqster commented Dec 7, 2023

Yes, I'd like to do more customer development here. Let's gather evidence that this is a blocking issue.
Hypothesis could be:

  • Users don't know how to save program files onto their computers
  • Users want to, but can't save program files (while in a tutorial) onto their computers
  • Users want to, but can't save program files (while working in a GitHub repo) onto their computers

This UI goes across all our targets, so if we find this is an issue and come up with a solution, I could imagine applying this across all our code editors (maybe not Minecraft?)

"name": "Download to Drive",
"description": "Download a copy of your game file to your computer",
"imageUrl": "/static/hardware/laptop.png",
"variant": "hw---stm32f401"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this compiling to stm32f401?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't have a variant that creates a png and this is the variant attached to the button people are most-likely to select if they use download today.

@riknoll suggested we would eventually want to do the work to make a .png variant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be thought through. We don't select variant when saving through save icon. Let's wait on this change for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants