Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Social cards don't remove HTML #10333

Open
carlosperate opened this issue Jan 6, 2025 · 1 comment
Open

Docs: Social cards don't remove HTML #10333

carlosperate opened this issue Jan 6, 2025 · 1 comment

Comments

@carlosperate
Copy link
Contributor

carlosperate commented Jan 6, 2025

In the docs, it looks like the twitter and OG social media metadata might keep any HTML tags used in the description. At least they are escaped, so maybe this is by design, but it might be worth removing the tag altogether.

For example in this page, the <strong> tags end up in the card:
https://makecode.microbit.org/online-learning

Image

And in the HTML we see:

<meta name="twitter:description" content="&lt;strong&gt;Microsoft Teams&lt;/strong&gt; is a collaboration hub for Office 365 where Educators can organize student groups into classes with content, conversations, apps, and assignments all in one place." />
<meta property="og:description" content="&lt;strong&gt;Microsoft Teams&lt;/strong&gt; is a collaboration hub for Office 365 where Educators can organize student groups into classes with content, conversations, apps, and assignments all in one place." />
@ssande-fwd
Copy link

When I set up a local version of makecode, the same page, /online-learning, seems to take the description from pxtarget.json. I wonder why it's not doing the same for the production site.

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants