Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork 'react/bridging/*' header files #13391

Open
Yajur-Grover opened this issue Jun 26, 2024 · 1 comment
Open

Unfork 'react/bridging/*' header files #13391

Yajur-Grover opened this issue Jun 26, 2024 · 1 comment

Comments

@Yajur-Grover
Copy link
Contributor

Yajur-Grover commented Jun 26, 2024

Summary

During the 6/13 integration, a new ReactCommon file EventEmitter.h was brought in from upstream, and added as an include into the TurboModule.h file, which was causing the following errors:

Error C1083 Cannot open include file: 'react/bridging/EventEmitter.h': No such file or directory PlaygroundNativeModules C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\TurboModule.h 17
Error C1083 Cannot open include file: 'react/bridging/EventEmitter.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\TurboModule.h 17
Error C1083 Cannot open include file: 'react/bridging/EventEmitter.h': No such file or directory playground C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\TurboModule.h 17  

These errors are the result of the path of the TurboModule.h having two ReactCommon directories, resulting in the Visual Studio looking in the wrong directory during the build process and throwing the above error.

In order to fix this issue, forks of EventEmitter.h, Function.h, Base.h and Convert.h in the react/bridigng directory in ReactCommon had to be made. Additionally, some slight modifications were also made to the include statements in LongLivedObject.h.

Motivation

Resolve path issue and errors being caused by it

Basic Example

No response

Open Questions

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 26, 2024
@Yajur-Grover Yajur-Grover changed the title Unfork 'react/bridging/EventEmitter.h' Unfork 'react/bridging/EventEmitter.h', 'react/bridging/Function.h' and 'react/bridging/Base.h' Jun 26, 2024
@Yajur-Grover Yajur-Grover changed the title Unfork 'react/bridging/EventEmitter.h', 'react/bridging/Function.h' and 'react/bridging/Base.h' Unfork 'react/bridging/*' header files Jun 27, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 27, 2024
@chrisglein chrisglein added this to the Backlog milestone Jun 27, 2024
@chrisglein
Copy link
Member

As is slated to be a permanent fork (not something waiting for an upstream change), related to our tools. Investigation into options for that happening while still not blocking the integration (thus the forks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants