Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

background color not working on image #3780

Closed
ddalp opened this issue Dec 16, 2019 · 1 comment
Closed

background color not working on image #3780

ddalp opened this issue Dec 16, 2019 · 1 comment
Labels
Area: Borders and Brushes Area: Image bug Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone
Backlog

Comments

@ddalp
Copy link
Contributor

ddalp commented Dec 16, 2019

It is related to the issue #3456 "ImageStyleProps borderRadius #3456". While the border properties are working after fix to #3456, background still does not work on Image. It is because we are using the Grid.Background brush to draw image already.

While initial attempt to solve the border and background issue together is to add a border element on top of the Image grid, it works almost all the cases except the broder does not intersect with the background, which is the currently behavior on Android and iOS. We may need something like :
Grid

  • Border (background and border properties)
  • Grid/Canvas(image brush for background)

Since I am not sure the priority of supporting background on image element, and it looks like the solution is going to be complicated (reparenting, transfer properties), I am leaving out the support for Background property for now and open this issue to track.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 16, 2019
@chrisglein chrisglein added Area: Borders and Brushes Area: Image and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jan 6, 2020
@chrisglein chrisglein added this to the MVP+ (vNext M5) milestone Jan 6, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog May 12, 2020
@chrisglein chrisglein added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 30, 2023
@chrisglein
Copy link
Member

Not something we plan to address on the Paper renderer as we move towards Fabric.
Fabric API completion is tracked here: #11144

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Borders and Brushes Area: Image bug Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@marlenecota @chrisglein @ddalp