Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image page in RNTester hits runtime assert #4691

Closed
asklar opened this issue Apr 23, 2020 · 7 comments
Closed

Image page in RNTester hits runtime assert #4691

asklar opened this issue Apr 23, 2020 · 7 comments

Comments

@asklar
Copy link
Member

asklar commented Apr 23, 2020

The page uses Image's resizeMode = repeat which is not currently supported and asserts in Debug builds. See #2111.

Results: the app crashes (no redbox, just a hard crash)

@asklar asklar added the bug label Apr 23, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 23, 2020
@NickGerleman
Copy link
Collaborator

We had this as a bug for a while, but it looks like @jonthysell fixed it #3738?

@NickGerleman
Copy link
Collaborator

Seems like there were seperate issues with the image example. I wonder if resizeMode is new.

@NickGerleman
Copy link
Collaborator

resizeMode "repeat" has been around for both Android + iOS since 0.56. @jonthysell do you know if the RNTesterExample page was working after your change? I assumed it was still broken during 0.62 validation.

@NickGerleman
Copy link
Collaborator

Confirmed this reproes in 0.61-stable.

@chrisglein
Copy link
Member

Created card (will upgrade to issue) for missing mode: https://github.com/microsoft/react-native-windows/projects/18#card-37114262
This should be a yellow box error, not an assert.
Should hook up unimplemented property to do that.

@chrisglein chrisglein added API: Completion Area: Image and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Apr 27, 2020
@chrisglein chrisglein added this to the 0.62 (M5) milestone Apr 27, 2020
@acoates-ms
Copy link
Contributor

This is how you show a yellowbox from native:
instance->CallJsFunction("RCTLog", "logToConsole", folly::dynamic::array("warn", "yellow box message goes here"));

Normally this kind of thing would go in a warnOnce which is a JS side thing. We'd probably want to only send the message once. Ideally per instance.

@asklar
Copy link
Member Author

asklar commented Apr 29, 2020

sent mail to @marlenecota who added the assert. I'll track adding the yellowbox separately since it's still useful to have the ability to easily surface errors in the UI, let's keep this bug for tracking the resizeMode=repeat assert (is the assert and comment in the code still applicable?)
introduced in: #3712
assert happens here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants