Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aarch64-unknown-linux-gnu release asset #23

Open
andreamah opened this issue Mar 15, 2023 · 3 comments
Open

Remove aarch64-unknown-linux-gnu release asset #23

andreamah opened this issue Mar 15, 2023 · 3 comments
Labels

Comments

@andreamah
Copy link
Contributor

In microsoft/vscode-ripgrep@a85a687, we change vscode-ripgrep to only consume aarch64-unknown-linux-musl for arm64 linux and not the gnu version. If nobody is using it, we should remove it as a released asset.

@andreamah andreamah self-assigned this Mar 15, 2023
@andreamah andreamah added the debt label Mar 15, 2023
@andreamah
Copy link
Contributor Author

#2
@Siddhesh-Ghadi @ghatwala We saw that you use these prebuilts for https://github.com/eclipse-che/che-theia. Would removing our aarch64-unknown-linux-gnu be an issue for you all?

@ghatwala
Copy link

hi @andreamah https://github.com/microsoft/ripgrep-prebuilt/pull/2/files here we had added support for power , z only and we wont be impacted at least by removing above but there may be others who are consuming this which we aren't aware of.

@andreamah
Copy link
Contributor Author

I see, thanks for the quick response. Since this repo only really supports the vscode-ripgrep repo, others are responsible for any breakages that happen from changes to this repo.

I just wanted to reach out because I was told that Theia also uses it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants