Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab.showCloseButton: hover|never + tabWidthMode: titleLength should have some padding on the left of the tab #13725

Open
7 of 8 tasks
zadjii-msft opened this issue Aug 11, 2022 · 4 comments
Open
7 of 8 tasks

tab.showCloseButton: hover|never + tabWidthMode: titleLength should have some padding on the left of the tab #13725

zadjii-msft opened this issue Aug 11, 2022 · 4 comments
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 11, 2022 •
edited
Loading

  • There should be a bit more space to the right of the tab title to match the left side (next to icon)
    image
Fixed in 1.16

From 1.16.2142.0 bash on Aug 2nd

additional

  • With "tab.showCloseButton" set to "hover": Height of inactive tabs change upon hover - (can't seem to post a GIF in OneNote so try it yourself)
    • Mike couldn't repro this, so maybe someone else can?
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Theming Anything related to the theming of elements of the window labels Aug 11, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Aug 11, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 11, 2022
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 12, 2022
@zadjii-msft zadjii-msft self-assigned this Aug 26, 2022
@zadjii-msft zadjii-msft mentioned this issue Aug 29, 2022
Merged
zadjii-msft added a commit that referenced this issue Aug 29, 2022
@zadjii-msft
Remove the useMica key
a8e9583 
It's not making it for 1.16, so it's out.
Closes a bullet point in #13725
@zadjii-msft zadjii-msft mentioned this issue Aug 29, 2022
Merged
@zadjii-msft

This comment was marked as resolved.

Sign in to view
@zadjii-msft

This comment was marked as resolved.

Sign in to view
ghost pushed a commit that referenced this issue Aug 29, 2022
@zadjii-msft
Remove the useMica key (#13872)
19b6d35 
It's not making it for 1.16, so it's out.
Closes a bullet point in #13725
@zadjii-msft zadjii-msft mentioned this issue Aug 31, 2022
Closed
2 tasks
ghost pushed a commit that referenced this issue Aug 31, 2022
@zadjii-msft
Fixes the color of the dropdown arrow in weird themes (#13871)
36f67d7 
See also:
https://github.com/microsoft/microsoft-ui-xaml/blob/33732458ede38166f9127675898e4760c82b89bb/dev/SplitButton/SplitButton.xaml#L290-L293

We need to 
* Also set `SplitButtonForegroundSecondary` cause SplitButton's use that resource separately from the `Foreground()` property
* Manually trigger the visual state change, to refresh the brushes. We do something similar in TabBase

This is one of the bullet points in #13725
zadjii-msft added a commit that referenced this issue Sep 1, 2022
@zadjii-msft
Remove the 1px gap under inactive tabs
6ebbc11 
As noted in microsoft/microsoft-ui-xaml#7674 (comment)

Screenshot below.

* [x] Closes a single element of #13725
@zadjii-msft zadjii-msft mentioned this issue Sep 1, 2022
Merged
1 task
ghost pushed a commit that referenced this issue Sep 1, 2022
@zadjii-msft
Remove the 1px gap under inactive tabs (#13897)
81ac976 
As noted in microsoft/microsoft-ui-xaml#7674 (comment)

Screenshot below.

* [x] Closes a single element of #13725
@pete-debiase
Copy link

pete-debiase commented Nov 2, 2022 •
edited
Loading

Apologies if this is not the right place to post this, but just wanted to add a +1 for There should be a bit more space to the right of the tab title to match the left side (next to icon) from the OP. The fact that tab titles are not centered with showCloseButton: never has been bugging me recently.

On a similar note, would it be feasible to remove the (erroneous?) straight line cutting through the rounded bottom left corner of each tab? This seems like it may be some kind of stray rendering artifact left over from when the tab is not active (if I'm seeing this right, the corner rounding is applied when the tab becomes active). Are the left and right sides of the tab handled differently? There is no cut-through in the bottom right corner of the tab.

image

@zadjii-msft zadjii-msft removed their assignment Jan 13, 2023
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Jan 13, 2023
@zadjii-msft zadjii-msft mentioned this issue Mar 1, 2023
Closed
@zadjii-msft zadjii-msft changed the title Theming nits from bug bash tab.showCloseButton: hover|never + tabWidthMode: titleLength should have some padding on the left of the tab Apr 4, 2023
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.18, Backlog Apr 4, 2023
@bradwilson
Copy link

Just ran across this, and this issue has been quiet for a while. Is this still planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@bradwilson @DHowett @carlos-zamora @pete-debiase @zadjii-msft