Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting string to password prompt fails. #2788

Closed
urtabajev opened this issue Sep 17, 2019 · 8 comments
Closed

Pasting string to password prompt fails. #2788

urtabajev opened this issue Sep 17, 2019 · 8 comments
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.

Comments

@urtabajev
Copy link

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.4.2382.0

Steps to reproduce

  1. Start ssh connection to host which asks password for authentication or use Python getpass.getpass()
  2. Paste string from clipboard buffer to prompt
  3. Correct information will not be pasted and and Python just stays waiting for input even after enter

Expected behavior

Correct string will be pasted to prompt and programs should continue as expected.

Actual behavior

Password prompts will not recieve pasted string correctly.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 17, 2019
@DHowett-MSFT
Copy link
Contributor

I can't reproduce this anywhere.
image

Can you provide a bit more information? What versions of what tools are you using? Has it ever worked?

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 17, 2019
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 18, 2019
@nidheekamble
Copy link

Like @DHowett-MSFT, I too am unable to reproduce the issue with the exact expected behaviour described in the issue. The pasted string isn't echoed, but it doesn't result in Python waiting for an input nonetheless.

Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 16:07:46) [MSC v.1900 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import getpass
>>> getpass.getpass()
Password:
'blahblah'
>>> getpass.getpass()
Password:
'\x16'
>>>

@urtabajev
Does this help? microsoft/knack#160

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Sep 23, 2019
@ghost
Copy link

ghost commented Sep 23, 2019

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Sep 26, 2019
@urtabajev
Copy link
Author

For me following reporoduces issue perfectly:

python3 -c "import getpass;your_pwd = getpass.getpass('Enter password: '); print(your_pwd)"

When typing in password then execution reaches to print but when pasting string enter after that does not work and I can't select anything from this terminal window also when input is stuck until exectuion is interrupted.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Sep 26, 2019
@urtabajev
Copy link
Author

Python in interactive mode, instead of normal mode will not reproduce issue.

@DHowett-MSFT DHowett-MSFT reopened this Sep 26, 2019
@urtabajev
Copy link
Author

Seems that Version: 0.5.2681.0 fixes it.

@zadjii-msft zadjii-msft added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. labels Oct 25, 2019
@DHowett-MSFT
Copy link
Contributor

Yep, I can't reproduce this on 0.6 either.

@DHowett-MSFT DHowett-MSFT added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Oct 29, 2019
@LazerFX
Copy link

LazerFX commented Nov 22, 2019

I suspect I may have a related issue (Reproducible on 0.6.2951.0):

I pasted my password into a docker logon prompt, which was an auto-generated, alphanumeric (string and number only, no special characters or tabs) API key. This pasted into the command line correctly, so I could (for instance) do an $env:docker-username=<apikey> and have it be visible, and then use a powershell script to apply the login value (As long-winded as this whole route turned out to be!); however, pasting directly into the docker login Password: prompt just responded with an unauthorised: BAD_CREDENTIAL response.

Pasting the same into either Windows CMD or Windows PowerShell (5 or 6.2) worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Projects
None yet
Development

No branches or pull requests

5 participants