Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the text that timed out in regex match #4175

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Show the text that timed out in regex match #4175

merged 4 commits into from
Nov 27, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 27, 2024 •
edited
Loading

Help diagnose #4159

Youssef1313
Youssef1313 previously approved these changes Nov 27, 2024
View reviewed changes
Evangelink
Evangelink reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a temp change that will be removed before we ship? If not then the exception message should be localized.

@nohwnd
Copy link
Member Author

nohwnd commented Nov 27, 2024

Thanks for pointing that out. localized so we can keep it for the future as well.

@nohwnd nohwnd enabled auto-merge (squash) November 27, 2024 11:42
@nohwnd nohwnd disabled auto-merge November 27, 2024 11:43
@nohwnd nohwnd enabled auto-merge (squash) November 27, 2024 11:43
@nohwnd nohwnd disabled auto-merge November 27, 2024 11:50
@nohwnd nohwnd merged commit 0b903b9 into main Nov 27, 2024
8 checks passed
@nohwnd nohwnd deleted the timeout branch November 27, 2024 11:51
nohwnd added a commit that referenced this pull request Nov 28, 2024
@nohwnd
Revert "Show the text that timed out in regex match (#4175)"
448339d 
This reverts commit 0b903b9.
@nohwnd nohwnd mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@Evangelink Evangelink Evangelink left review comments

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nohwnd @Evangelink @Youssef1313