fix(2015): abstract property created, overshadowing override (#2016)

Author: a-tarasyuk

internal/transformers/tstransforms/typeeraser.go

@@ -121,7 +121,7 @@ func (tx *TypeEraserTransformer) visit(node *ast.Node) *ast.Node {
 		return tx.Factory().UpdateExpressionWithTypeArguments(n, tx.Visitor().VisitNode(n.Expression), nil)
 
 	case ast.KindPropertyDeclaration:
-		if ast.HasSyntacticModifier(node, ast.ModifierFlagsAmbient) {
+		if ast.HasSyntacticModifier(node, ast.ModifierFlagsAmbient|ast.ModifierFlagsAbstract) {
 			// TypeScript `declare` fields are elided
 			return nil
 		}

testdata/baselines/reference/submodule/compiler/abstractPropertyBasics.js

@@ -25,9 +25,6 @@ class C extends B {
 
 //// [abstractPropertyBasics.js]
 class B {
-    prop;
-    raw;
-    ro;
 }
 class C extends B {
     get prop() { return "foo"; }

testdata/baselines/reference/submodule/compiler/abstractPropertyBasics.js.diff

@@ -1,12 +1,7 @@
 --- old.abstractPropertyBasics.js
 +++ new.abstractPropertyBasics.js
-@@= skipped -24, +24 lines =@@
-
- //// [abstractPropertyBasics.js]
+@@= skipped -26, +26 lines =@@
  class B {
-+    prop;
-+    raw;
-+    ro;
  }
  class C extends B {
 -    constructor() {

testdata/baselines/reference/submodule/compiler/abstractPropertyInConstructor.js

@@ -111,8 +111,6 @@ class AbstractClass {
         // OK, references are to another instance
         other.cb(other.prop);
     }
-    prop;
-    cb;
     other = this.prop;
     fn = () => this.prop;
     method2() {
@@ -151,8 +149,6 @@ class User {
     }
 }
 class C1 {
-    x;
-    y;
     constructor() {
         let self = this; // ok
         let { x, y: y1 } = this; // error

testdata/baselines/reference/submodule/compiler/abstractPropertyInConstructor.js.diff

@@ -13,8 +13,6 @@
          // OK, references are to another instance
          other.cb(other.prop);
      }
-+    prop;
-+    cb;
 +    other = this.prop;
 +    fn = () => this.prop;
      method2() {
@@ -29,7 +27,7 @@
          // there is no implementation of 'prop' in any base class
          this.cb(this.prop.toLowerCase());
          this.method(1);
-@@= skipped -17, +21 lines =@@
+@@= skipped -17, +19 lines =@@
      }
  }
  class Implementation extends DerivedAbstractClass {
@@ -42,16 +40,7 @@
          this.cb(this.prop);
      }
      method(n) {
-@@= skipped -19, +19 lines =@@
-     }
- }
- class C1 {
-+    x;
-+    y;
-     constructor() {
-         let self = this; // ok
-         let { x, y: y1 } = this; // error
-@@= skipped -7, +9 lines =@@
+@@= skipped -26, +26 lines =@@
      }
  }
  class C2 {

testdata/baselines/reference/submodule/compiler/abstractPropertyNegative.js

@@ -47,17 +47,13 @@ abstract class AbstractAccessorMismatch {
 
 //// [abstractPropertyNegative.js]
 class B {
-    prop;
-    ro;
 }
 class C extends B {
     ro = "readonly please";
-    notAllowed;
 }
 let c = new C();
 c.ro = "error: lhs of assignment can't be readonly";
 class WrongTypeProperty {
-    num;
 }
 class WrongTypePropertyImpl extends WrongTypeProperty {
     num = "nope, wrong";

testdata/baselines/reference/submodule/compiler/abstractPropertyNegative.js.diff

@@ -1,11 +1,7 @@
 --- old.abstractPropertyNegative.js
 +++ new.abstractPropertyNegative.js
-@@= skipped -46, +46 lines =@@
-
- //// [abstractPropertyNegative.js]
+@@= skipped -48, +48 lines =@@
  class B {
-+    prop;
-+    ro;
  }
  class C extends B {
 -    constructor() {
@@ -14,12 +10,10 @@
 -    }
 -    get concreteWithNoBody() { }
 +    ro = "readonly please";
-+    notAllowed;
  }
  let c = new C();
  c.ro = "error: lhs of assignment can't be readonly";
  class WrongTypeProperty {
-+    num;
  }
  class WrongTypePropertyImpl extends WrongTypeProperty {
 -    constructor() {
@@ -30,7 +24,7 @@
  }
  class WrongTypeAccessor {
  }
-@@= skipped -24, +21 lines =@@
+@@= skipped -22, +15 lines =@@
      get num() { return "nope, wrong"; }
  }
  class WrongTypeAccessorImpl2 extends WrongTypeAccessor {

testdata/baselines/reference/submodule/conformance/abstractProperty(target=es2015).js

@@ -19,7 +19,6 @@ class C extends A {
 
 //// [abstractProperty.js]
 class A {
-    x;
     foo() {
         console.log(this.x);
     }

testdata/baselines/reference/submodule/conformance/abstractProperty(target=es2015).js.diff

@@ -1,12 +1,6 @@
 --- old.abstractProperty(target=es2015).js
 +++ new.abstractProperty(target=es2015).js
-@@= skipped -18, +18 lines =@@
-
- //// [abstractProperty.js]
- class A {
-+    x;
-     foo() {
-         console.log(this.x);
+@@= skipped -23, +23 lines =@@
      }
  }
  class B extends A {

testdata/baselines/reference/submodule/conformance/abstractProperty(target=esnext).js

@@ -19,7 +19,6 @@ class C extends A {
 
 //// [abstractProperty.js]
 class A {
-    x;
     foo() {
         console.log(this.x);
     }