Fix IsTopLevelValueImportEqualsWithEntityName

Author: jakebailey

internal/checker/emitresolver.go

@@ -762,7 +762,7 @@ func (r *emitResolver) IsTopLevelValueImportEqualsWithEntityName(node *ast.Node)
 		return false
 	}
 	if ast.IsImportEqualsDeclaration(node) &&
-		(ast.NodeIsMissing(node.AsImportEqualsDeclaration().ModuleReference) || node.AsImportEqualsDeclaration().ModuleReference.Kind != ast.KindExternalModuleReference) {
+		(ast.NodeIsMissing(node.AsImportEqualsDeclaration().ModuleReference) || node.AsImportEqualsDeclaration().ModuleReference.Kind == ast.KindExternalModuleReference) {
 		return false
 	}
 

internal/transformers/tstransforms/importelision.go

@@ -27,8 +27,16 @@ func NewImportElisionTransformer(opt *transformers.TransformOptions) *transforme
 func (tx *ImportElisionTransformer) visit(node *ast.Node) *ast.Node {
 	switch node.Kind {
 	case ast.KindImportEqualsDeclaration:
-		if !tx.isElisionBlocked(node) && !tx.shouldEmitImportEqualsDeclaration(node.AsImportEqualsDeclaration()) {
-			return nil
+		if !tx.isElisionBlocked(node) {
+			if ast.IsExternalModuleImportEqualsDeclaration(node) {
+				if !tx.shouldEmitAliasDeclaration(node) {
+					return nil
+				}
+			} else {
+				if !tx.shouldEmitImportEqualsDeclaration(node.AsImportEqualsDeclaration()) {
+					return nil
+				}
+			}
 		}
 		return tx.Visitor().VisitEachChild(node)
 	case ast.KindImportDeclaration:

testdata/baselines/reference/submodule/compiler/aliasBug.js

@@ -38,6 +38,7 @@ var foo;
     })(bar = foo.bar || (foo.bar = {}));
 })(foo || (foo = {}));
 var provide = foo;
+var booz = foo.bar.baz;
 var p = new provide.Provide();
 function use() {
     var p1; // error here, but should be okay

testdata/baselines/reference/submodule/compiler/aliasBug.js.diff

@@ -49,10 +49,14 @@ var foo;
     })(bar = foo.bar || (foo.bar = {}));
 })(foo || (foo = {}));
 var provide = foo;
+var booz = foo.bar.baz;
 var beez = foo.bar;
+var m = no;
+var m2 = no.mod;
 5;
 "s";
 null;
+var r = undefined;
 var p = new provide.Provide();
 function use() {
     beez.baz.boo;

testdata/baselines/reference/submodule/compiler/aliasErrors.js

@@ -13,3 +13,4 @@ var a;
     a.b = 10;
 })(a || (a = {}));
 var f = () => this;
+var _this = a; // Error

testdata/baselines/reference/submodule/compiler/aliasErrors.js.diff

@@ -13,3 +13,4 @@ var M;
 (function (M) {
     M.x = 1;
 })(M || (M = {}));
+var a = M;