Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cadl-Ranch scenario - Explode parameter is always false even when it should be true #5134

Closed
JoshLove-msft opened this issue Nov 15, 2024 · 0 comments · Fixed by #5396
Closed

Cadl-Ranch scenario - Explode parameter is always false even when it should be true #5134

JoshLove-msft opened this issue Nov 15, 2024 · 0 comments · Fixed by #5396
Assignees
@jorgerangel-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

Need to investigate why explode is always false, even when it should be true. For instance, https://github.com/Azure/cadl-ranch/blob/main/packages/cadl-ranch-specs/http//routes/main.tsp#L400.
@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 15, 2024
@JoshLove-msft JoshLove-msft mentioned this issue Nov 15, 2024
Closed
@JoshLove-msft JoshLove-msft changed the title Explode parameter is always false even when it should be true Cadl-Ranch scenario - Explode parameter is always false even when it should be true Dec 3, 2024
@jorgerangel-msft jorgerangel-msft self-assigned this Dec 4, 2024
@jorgerangel-msft jorgerangel-msft mentioned this issue Jan 9, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 15, 2025
@jorgerangel-msft
[http-client-csharp]: Fix explode not being properly set for operatio…
2a8d12c 
…n params (#5396)

This PR fixes an issue where the `explode` flag for a operation
parameter was not being properly set when uri templates were specified.
This is fixed now by passing through the value of `explode` from TCGC.

There are several follow ups that are still needed to fully support URI
templates and path expansion.

fixes: #5134
regen preview for autorest:
Azure/azure-sdk-for-net#47775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgerangel-msft jorgerangel-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
2 participants
@JoshLove-msft @jorgerangel-msft