Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icu] Add option to specify --with-data-packaging #42410

Open
Poldraunic opened this issue Nov 28, 2024 · 4 comments
Open

[icu] Add option to specify --with-data-packaging #42410

Poldraunic opened this issue Nov 28, 2024 · 4 comments
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@Poldraunic
Copy link
Contributor

Is your feature request related to a problem? Please describe.

ICU supports multiple ways of packaging data files. The behaviour is controlled by --with-data-packaging argument during configuration.

More info here: https://unicode-org.github.io/icu/userguide/icu_data/#building-and-linking-against-icu-data

Proposed solution

Add a "feature" for every option?

Describe alternatives you've considered

No response

Additional context

No response

@Poldraunic Poldraunic added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 28, 2024
@Poldraunic
Copy link
Contributor Author

Poldraunic commented Nov 28, 2024

I don't mind take it on myself, I am just not sure how to go about it.

@Osyotr
Copy link
Contributor

Osyotr commented Nov 29, 2024

Add a "feature" for every option?

Alternatives should go through triplet. Example: osg.

@Poldraunic
Copy link
Contributor Author

@Osyotr ooh, nice! Thank you.

That's exactly what I was looking for. I'll whip something up next week for the ICU.

@Poldraunic
Copy link
Contributor Author

Poldraunic commented Dec 3, 2024

The osg way does work, but something during compilation goes wrong when using files or archive packaging option.

From what I could gather there was/is an issue where icudata.lst file is not generated (?) in time:

  1. https://trac.macports.org/ticket/17203
  2. https://github.com/microsoft/vcpkg/blob/3edabbe1407e2d4d8ce5b78bab8abf42cc966d10/ports/icu/fix_parallel_build_on_windows.patch

I am seeing the same error message as in the first link:

/bin/sh: line 1: out/tmp/icudata.lst: No such file or directory
make[1]: *** [Makefile:274: out/tmp/icudata.lst] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:153: all-recursive] Error 2

I've tried using one thread for compilation, but got the same error. This leads to me believe that something else is going on here. No idea how to fix it though. I am a noob when it comes to Autoconf/Make. My branch is here if anyone wants to take a peek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

No branches or pull requests

3 participants