Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoToDefinition stop working when upgrading to vscode 17.4.1 (or 17.4.2) on MAC #84

Open
GiardEmilien opened this issue Dec 21, 2022 · 4 comments

Comments

@GiardEmilien
Copy link

Hello,

I just updated my vscode to the latest version and I lost the ability to go to definition (cmd + click) when Atom Keybinding is activated.

Do you know what could cause this issue?
Thank you

Here is my config :

Version : 1.74.2
Validation : e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date : 2022-12-20T10:26:09.430Z
Electron : 19.1.8
Chromium : 102.0.5005.167
Node.js : 16.14.2
V8 : 10.2.154.15-electron.0
Système d’exploitation : Darwin x64 21.6.0
Sandboxé : No

@clemmyn23
Copy link

clemmyn23 commented Dec 22, 2022

Same issue, but on Windows.
To fix, set "editor.multiCursorModifier": "alt" in settings.json.

@clemmyn23
Copy link

Looks to be a change from this PR #82 that added a line

"editor.multiCursorModifier": "ctrlCmd",

But the PR itself looks fine and the newly added multicursorModifier property in package.json just replicates what the old extension.js code does, which is to change multicursorModifier to ctrlCmd.

The multicursorModifier vscode value have been defaulting to "alt" since its introduction 5 years ago.

I have no idea why this behaviour has changed and don't want to dive any deeper into this rabbit hole 🙈

@francoism90
Copy link

Same here, thanks @clemmyn23 for a quick workaround. :)

@shtefanilie
Copy link

Same issue here, #85 is a duplicate of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@francoism90 @clemmyn23 @GiardEmilien @shtefanilie and others