Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Logger consumers to customize log output #201

Open
roblourens opened this issue Sep 19, 2018 · 0 comments
Open

Allow Logger consumers to customize log output #201

roblourens opened this issue Sep 19, 2018 · 0 comments
Assignees
@roblourens
Labels
feature-request Request for new features or functionality
Milestone
Backlog

Comments

@roblourens
Copy link
Member

microsoft/vscode-chrome-debug-core#355 tries to clean script contents from logged messages, and it's a very awkward hack via patching a method on Logger. We should provide a nice way for consumers to customize the output.

We can add protected methods to the LoggingDebugSession that format log messages, so they can be overridden.
@roblourens roblourens self-assigned this Sep 19, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 19, 2018
@roblourens roblourens mentioned this issue Sep 19, 2018
Merged
@roblourens roblourens modified the milestones: October 2018, November 2018 Nov 1, 2018
@roblourens roblourens modified the milestones: November 2018, Backlog Nov 30, 2018
@weinand weinand added the feature-request Request for new features or functionality label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@roblourens @weinand