-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better collaboration with vscode-java #953
Comments
When I last looked at this I couldn't understand it, as buildship and this extension are both using the Gradle Tooling API, so it should be using the same daemon. It's definitely a good idea to reach out to vscode-java to try understand why different daemons are spawned. |
I have done some investigation, and here are some thoughts and findings: The target of this work is to reduce the daemon number of VS Code users. Now vscode-java will launch a daemon via buildship, and vscode-gradle will launch a daemon via TAPI directly, it will bring a waste of memory and resource. eclipse.jdt.ls (language server of vscode-java) uses buildship to import and manage Gradle projects, there is a long running instance
IMO it's doable for us to make our server an extension of eclipse.jdt.ls, get it's running Some concerns:
|
Another observation is that there are some unhealthy |
Taken together, there is no need to change. Because when we obtain information, we need lightweight, fast and real-time services. |
@mozhuanzuojing FYI, we are working on #1088, which will simplify the daemon numbers of the extension. After this change merged, the extension will use only a single daemon all the time, on the other hand, java extension will have its own daemon. This is the first step we work on this issue. |
Currently
vscode-gradle
starts a different daemon fromvscode-java
, we can find a way to reuse it, such as send our requests to language server, etc.The text was updated successfully, but these errors were encountered: