Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Store the schema version of the BSP project after import #1395

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Aug 28, 2023

I didn't find a way to add 'args' to a nature in .project. So use a plugin specific file to store the schema.

@jdneo jdneo requested a review from testforstephen as a code owner August 28, 2023 08:16
@jdneo
Copy link
Member Author

jdneo commented Aug 29, 2023

Another two options are:

  • Put a comment into the project description file. But since the comment might be replaced by anyone, so this would not be a good choice.
  • Put the version as an argument of the Builder, this should work but feels really strange.

@testforstephen
Copy link
Contributor

Did you try ProjectDescription.setVariableDescription(...) API, it supports adding more description to the .project file?

@testforstephen
Copy link
Contributor

Here is an example:

<projectDescription>
...
	<variableList>
		<variable>
			<name>bspSchemaVersion</name>
			<value>0.1.0</value>
		</variable>
	</variableList>
</projectDescription>

@jdneo
Copy link
Member Author

jdneo commented Aug 29, 2023

Did you try ProjectDescription.setVariableDescription(...) API, it supports adding more description to the .project file?

Looks promising! I was not aware of this, thank you!

@jdneo jdneo merged commit 51f2162 into develop Aug 29, 2023
17 checks passed
@jdneo jdneo deleted the cs/schema branch August 29, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants