Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format section into the project setting page. #1324

Merged
merged 2 commits into from
May 20, 2024

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented May 14, 2024

  • Click the formatter from nav side will open a new window for formatter page.
  • Move the project select to the top level of the page.
  • Move the apply button to the top level of the page.

- Click the formatter from nav side will open a new window for formatter page.
- Move the project select to the top level of the page.
- Move the apply button to the top level of the page.
@jdneo jdneo requested a review from testforstephen as a code owner May 14, 2024 05:46
@jdneo
Copy link
Member Author

jdneo commented May 14, 2024

Screen.Recording.2024-05-14.at.13.45.03.mov

Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor issue is that when I use "Configure Java Runtime" command to open the webview, it doesn't jump to the JDK tab page at the first time.

@jdneo
Copy link
Member Author

jdneo commented May 20, 2024

when I use "Configure Java Runtime" command to open the webview, it doesn't jump to the JDK tab page at the first time.

Tracked by #1330

@jdneo jdneo merged commit b937c94 into main May 20, 2024
4 checks passed
@jdneo jdneo deleted the cs/project-setting/formatter branch May 20, 2024 03:03
@SERE026
Copy link

SERE026 commented Dec 5, 2024

image @[jdneo](https://github.com/jdneo) jdneo mentioned this pull request [on May 20](https://github.com//pull/1324#ref-issue-2267309680) https://github.com//issues/1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants