Skip to content

Commit

Permalink
Track usage even if an uri does not already exist (#14321)
Browse files Browse the repository at this point in the history
  • Loading branch information
DonJayamanne authored Sep 13, 2023
1 parent 024313d commit 090cd34
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/kernels/jupyter/connection/serverUriStorage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { EventEmitter, Memento, Uri, env } from 'vscode';
import { inject, injectable, named } from 'inversify';
import { IEncryptedStorage } from '../../../platform/common/application/types';
import { Identifiers, JUPYTER_HUB_EXTENSION_ID, JVSC_EXTENSION_ID, Settings } from '../../../platform/common/constants';
import { Identifiers, Settings } from '../../../platform/common/constants';
import { IMemento, GLOBAL_MEMENTO, IExtensionContext, IDisposableRegistry } from '../../../platform/common/types';
import { traceError, traceInfoIfCI, traceVerbose } from '../../../platform/logging';
import {
Expand Down Expand Up @@ -347,13 +347,6 @@ class NewStorage {
const existingEntry = uriList.find(
(entry) => entry.provider.id === server.id && entry.provider.handle === server.handle
);
if (
!existingEntry &&
server.extensionId !== JVSC_EXTENSION_ID &&
server.extensionId !== JUPYTER_HUB_EXTENSION_ID
) {
throw new Error(`Uri not found for Server Id ${JSON.stringify(server)}`);
}
const entry: IJupyterServerUriEntry = {
provider: server,
time: Date.now(),
Expand Down

0 comments on commit 090cd34

Please sign in to comment.