Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create at least one IW test that has a @mandatory tag added to the test name #12304

Open
DonJayamanne opened this issue Dec 4, 2022 · 0 comments · May be fixed by #12329
Open

Create at least one IW test that has a @mandatory tag added to the test name #12304

DonJayamanne opened this issue Dec 4, 2022 · 0 comments · May be fixed by #12329
Assignees
@amunger
Labels
debt Code quality issues interactive-window Impacts interactive window

Comments

@DonJayamanne
Copy link
Contributor

The @mandatory test tag is added to ensure that a PR can safely be merged knowing that mandatory features/tests pass.
It would be good to have at least one IW test that has a @mandatory tag added to a test.

Currently PRs are blocked on ensuring all jobs containing the text @mandatory will always pass
With the way things stand, its possible for all IW tests to pass an a PR get merged.

Screenshot 2022-12-05 at 09 29 38
@DonJayamanne DonJayamanne added the debt Code quality issues label Dec 4, 2022
@amunger amunger added the interactive-window Impacts interactive window label Dec 5, 2022
@amunger amunger linked a pull request Dec 6, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amunger amunger

Labels
debt Code quality issues interactive-window Impacts interactive window
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make common IW test mandatory microsoft/vscode-jupyter
2 participants
@DonJayamanne @amunger