Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget tests fail when closing/reopening notebooks with saved widget output #8748

Closed
DonJayamanne opened this issue Jan 20, 2022 · 2 comments
Assignees
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jan 20, 2022

Problem with this test is simple, when we open a notebook with an existing widget output,
then the widget renderer loads first, not the test script, even though the
test scripts have been defined in the controller script dependencies as the first script in list of scripts to be loaded.
Hence the widget renderer cannot find the test script and we cannot communicate with the widget renderer.

@DonJayamanne DonJayamanne added engineering ipywidgets Rendering, loading, saving, anything to do with IPyWidgets labels Jan 20, 2022
@DonJayamanne DonJayamanne self-assigned this Jan 20, 2022
@greazer greazer added debt Code quality issues and removed needs-triage labels Jan 20, 2022
@DonJayamanne
Copy link
Contributor Author

Can be fixed using IPyWidgets 8 (new protocol methods in kernel)

@DonJayamanne DonJayamanne added this to the Backlog milestone Dec 4, 2023
@DonJayamanne
Copy link
Contributor Author

Closing in favour of #14856

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets
Projects
None yet
Development

No branches or pull requests

2 participants