Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'makefile.configureOnOpen=true' is suddenly added to workspace setting #677

Open
myocytebd opened this issue Dec 10, 2024 · 3 comments
Open
Labels
more info needed More info is needed from the community for us to properly triage and investigate

Comments

@myocytebd
Copy link

makefile-tools: v0.11.13
cpptools: v1.22.11
VSCode

Version: 1.95.3
Commit: f1a4fb101478ce6ec82fe9627c43efbf9e98c813
Date: 2024-11-13T14:50:04.152Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Linux x64 6.8.0-49-generic

After disable another extension (in workspace) and click 'restart extension', makefile-tools auto started a configuration despite global 'makefile.configureOnOpen=false'.
Then I found that workspace setting is modified with 'makefile.configureOnOpen=true'. Of course, I didn't change it.
The modification time of .vscode/settings.json is almost the time makefile-tools auto started a configuration.

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 8af32be3..cd5edaa2 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,5 +1,4 @@
 {
-    "C_Cpp.default.configurationProvider": "ms-vscode.makefile-tools",
     "files.associations": {
         "algorithm": "cpp",
         "cctype": "cpp",
@@ -70,5 +69,7 @@
         "valarray": "cpp",
         "codecvt": "cpp"
     },
-    "makefile.makefilePath": "GNUmakefile"
+    "makefile.makefilePath": "GNUmakefile",
+    "makefile.configureOnOpen": true,
+    "C_Cpp.default.configurationProvider": "ms-vscode.makefile-tools"
 }
@gcampbell-msft
Copy link
Collaborator

@myocytebd Is it regularly reproducible? If so, it would be great if you could tell us the steps to reproduce this so that we can investigate

@myocytebd
Copy link
Author

@myocytebd Is it regularly reproducible? If so, it would be great if you could tell us the steps to reproduce this so that we can investigate

No, it happened once yesterday.

@Yingzi1234
Copy link
Collaborator

@myocytebd We couldn't reproduce your issue, the exact reproduction steps are below, could you see if any of them are different from yours? And it would be great if you could provide us with a detailed step-by-step video of your reproduction!

Repro steps:

  1. Set the Makefile: ConfigureOnOpen setting to false
  2. Click "Restart extension" with an extension
  3. Check the Output window(Makefile)
    Image

@Yingzi1234 Yingzi1234 added more info needed More info is needed from the community for us to properly triage and investigate and removed triage labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info needed More info is needed from the community for us to properly triage and investigate
Projects
None yet
Development

No branches or pull requests

3 participants