Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@-ms-viewport is STILL an error #121138

Closed
ctro99 opened this issue Apr 12, 2021 · 1 comment
Closed

@-ms-viewport is STILL an error #121138

ctro99 opened this issue Apr 12, 2021 · 1 comment
Assignees
Labels
grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@ctro99
Copy link

ctro99 commented Apr 12, 2021

  • VS Code Version: 1.55.1 (Universal)
  • OS Version: macOS Big Sur 11.2.3 (20D91)

Steps to Reproduce:

  1. Create an HTML file with a CSS style block in the head
  2. Add this code within your style
    @-ms-viewport {
    width: device-width;
    }
  3. Now VS Code will not display your theme colors properly.

Does this issue occur when all extensions are disabled?: Yes

@alexr00
Copy link
Member

alexr00 commented Apr 14, 2021

We recently moved to a different CSS grammar for providing syntax highlighting. The old one was unmaintained, and the new one has good fixes in it. You can see the full discussion here: #115480

Specifically, see #115480 (comment), which references viewport as a deprecated feature (details https://developer.mozilla.org/en-US/docs/Web/CSS/@viewport). Even though the new grammar is missing ms-viewport, we decided to go with it because the benefits of having a maintained grammar outweighed the negative of missing the deprecated ms-viewport.

If you feel strongly that this is essential for the grammar, I recommend going to https://github.com/atom/language-css/, the repo that we pull our css grammar from, and filing an issue there to ask for ms-viewport to be supported in their textmate grammar.

@alexr00 alexr00 closed this as completed Apr 14, 2021
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Apr 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants