Autocomplete suggestions are no longer read with NVDA

[Neurrone]

Type: Bug

With NVDA, type something that triggers autocomplete.

Notice that nothing is announced when the menu appears. Pressing up/down to go through autocomplete suggestions also doesn't read anything.

This worked yesterday, so this is a very recent regression.

VS Code version: Code - Insiders 1.96.0-insider (9086857, 2024-11-22T09:56:24.579Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Remote OS version: Linux x64 5.15.167.4-microsoft-standard-WSL2

System Info

Item	Value
CPUs	AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics (16 x 3294)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	undefined
Memory (System)	62.72GB (47.27GB free)
Process Argv	--folder-uri=vscode-remote://wsl+ubuntu/home/dickson/source/leetcode-2024 --remote=wsl+ubuntu
Screen Reader	yes
VM	40%

Item	Value
Remote	WSL: ubuntu
OS	Linux x64 5.15.167.4-microsoft-standard-WSL2
CPUs	AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics (16 x 0)
Memory (System)	30.72GB (29.09GB free)
VM	0%

Extensions (17)

Extension	Author (truncated)	Version
remote-containers	ms-	0.391.0
remote-ssh	ms-	0.115.1
remote-ssh-edit	ms-	0.87.0
remote-wsl	ms-	0.88.5
vscode-remote-extensionpack	ms-	0.26.0
remote-explorer	ms-	0.4.3
remote-server	ms-	1.5.2
nvda-indent-nav-accessibility	Ton	1.0.0
astro-vscode	ast	2.15.4
vscode-eslint	dba	3.0.10
dendron	den	0.124.0
dendron-paste-image	den	1.1.1
prettier-vscode	esb	11.0.0
debugpy	ms-	2024.12.0
python	ms-	2024.20.0
vscode-pylance	ms-	2024.11.3
rust-analyzer	rus	0.4.2193

[Neurrone]

Cc @isidorn

[Neurrone]

Latest version is bad, 1.96.0.20241122 user installer

Version: 1.96.0-insider (user setup)
Commit: 90868576241dd25c6c5da64adadc0a09de91a9fe
Date: 2024-11-22T09:56:24.579Z
Electron: 32.2.5
ElectronBuildId: 10579404
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631

Last good version that doesn't have this bug is the one before that, 1.96.0.20241121 user installer

Version: 1.96.0-insider (user setup)
Commit: 69acde7458f428f0e6869de8915c9dd995cdda1a
Date: 2024-11-21T05:04:38.064Z
Electron: 32.2.5
ElectronBuildId: 10579404
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631

[isidorn]

Sounds like a regression in insiders. Fyi @meganrogge

[meganrogge]

@aiday-mar bisected this to b69589c

[aiday-mar]

Hi thanks for filing this issue. This is a bug with the EditContext enablement. To temporarily fix this issue, you may turn the following setting off: editor.experimentalEditContextEnabled. In the meantime, I will look for a fix.

[Neurrone]

Given the severity of this issue, it should be turned off by default.

In the same version this issue was introduced, another much more critical regression #234466 was also introduced. Given the setting is called edit context, I wonder if it is related, since these issues occured at the same time.

[aiday-mar]

Hi thank you for posting this. I will have a look. I may have to turn off the edit context until the problems are resolved, I will keep you updated.

[aiday-mar]

Hi thank you for filing this issue, this seems to be related to the combination of the edit context and the screen reader mode being enabled. I will turn off the edit context by default on Insiders, investigate all the issues and turn it back on later.

[aiday-mar]

The PR that reverts the enablement : #234638. I will investigate the issues you and @meganrogge filed

[Neurrone]

Thanks!