Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native context menu hijacks custom one in webview editor #239862

Open
dvdrtrgn opened this issue Feb 6, 2025 · 15 comments
Open

Native context menu hijacks custom one in webview editor #239862

dvdrtrgn opened this issue Feb 6, 2025 · 15 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron regression Something that used to work is now broken

Comments

@dvdrtrgn
Copy link

dvdrtrgn commented Feb 6, 2025

Type: Bug

VS code january...

Open Git Graph and right-click an item.

The context menu shows only text operations.

VS Code version: Code 1.97.0 (Universal) (33fc5a9, 2025-02-04T22:41:26.688Z)
OS version: Darwin arm64 23.6.0
Modes:

System Info
Item Value
CPUs Apple M2 Pro (10 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.11GB free)
Process Argv --crash-reporter-id 0e8e2e6e-1b7c-420f-80bc-68c11cd9ef00
Screen Reader no
VM 0%
Extensions (44)
Extension Author (truncated) Version
better-comments aar 3.0.2
Bookmarks ale 13.5.0
project-manager ale 12.8.0
aws-toolkit-vscode ama 3.45.0
browse-lite ant 0.3.9
goto-alias ant 0.2.1
vscode-apollo apo 2.5.4
lit-html bie 1.11.1
vscode-intelephense-client bme 1.12.6
vscode-tailwindcss bra 0.14.3
path-intellisense chr 2.10.0
codestream Cod 15.20.0
vscode-eslint dba 3.0.10
githistory don 0.6.20
gitlens eam 16.2.2
vscode-diff fab 2.1.2
macros ged 1.2.1
gitlab-workflow Git 5.38.0
todo-tree Gru 0.0.226
vscode-peacock joh 4.2.2
string-manipulation mar 0.7.25
git-graph mhu 1.30.0
debugpy ms- 2025.0.0
python ms- 2025.0.0
vscode-pylance ms- 2025.2.1
atom-keybindings ms- 3.3.0
vsliveshare ms- 1.0.5948
vscode-twoslash-queries Ort 1.5.0
advanced-new-file pat 1.2.2
laravel-jump-controller pgl 0.0.33
postman-for-vscode Pos 1.7.0
vscode-thunder-client ran 2.34.0
vscode-yaml red 1.15.0
LiveServer rit 5.7.9
open-in-browser tec 2.0.0
es6-string-html Tob 2.17.0
pdf tom 1.2.2
sort-lines Tyr 1.12.0
explorer vit 1.10.7
vscode-icons vsc 12.11.0
volar Vue 2.2.0
snippet-generator wen 0.3.8
pretty-ts-errors Yoa 0.6.1
type-challenges YRM 1.15.0
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dwnewjupyter:31046869
nativerepl1:31139838
pythonrstrctxt:31112756
nativeloc2:31192216
iacca1:31171482
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
6074i472:31201624
customenabled:31232589
8did9651:31230678
9064b325:31222308
copilot_t_ci:31222730

@dminhhoang26
Copy link

yes, im in the same issue

@gjsjohnmurray
Copy link
Contributor

Have you reported it to the extension author yet?

@barneyzhao
Copy link

Same issue here.

It's reported to the extension author, but looks like they're not maintaining the project anymore.

According to @ammarsdc, the extension context menu works in version 1.96.4

@cdpark0530
Copy link

Same, thank you for the report

@bpasero bpasero added electron Issues and items related to Electron confirmed Issue has been confirmed by VS Code Team member labels Feb 7, 2025
@bpasero bpasero assigned deepak1556 and unassigned lszomoru Feb 7, 2025
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken labels Feb 7, 2025
@bpasero
Copy link
Member

bpasero commented Feb 7, 2025

Bisect points to: 151ef35...fca210c

@deepak1556 looks like the minor Electron update caused this.

Install https://marketplace.visualstudio.com/items?itemName=mhutchie.git-graph and click on the status bar entry.

Before:

Image

After:

Image

It seems to me that "before" a custom menu from the webview opened and now a native menu. You can see the visual difference.

@bpasero bpasero changed the title Context menu missing Native context menu hijacks custom one in webview editor Feb 7, 2025
@lszomoru lszomoru assigned lszomoru and unassigned lszomoru Feb 7, 2025
@deepak1556
Copy link
Collaborator

deepak1556 commented Feb 7, 2025

Issue seems to be from contextmenu event being fired twice on an element that messes up the state managed by this extension. It got regressed with electron/electron#44954 due to missing return after the first dispatch.

Edit: It has been addressed in electron/electron#44978 which is available with 34.x.y

@hoangnq3004
Copy link

There is a temporary solution is right click on the left margin of the git-graph window, the context menu will appear

Image

@deepak1556
Copy link
Collaborator

Fix backported in https://devdiv.visualstudio.com/DevDiv/_git/electron-build/commit/5ab0ea02f205badc9322c907bba193b9b7ae4751?refName=refs/heads/robo/hotfix/release_32_x_y

@reidsneo
Copy link

No new vscode push update?
this is really annoying bug

@git-hub-tig
Copy link

Solved with upgraded extension Git Graph 3

@mitjakukovec
Copy link

Solved with upgraded extension Git Graph 3

It's probably nothing serious, but I get this when trying to install

Image

@captain-corgi
Copy link

Experienced the same

@git-hub-tig
Copy link

Solved with upgraded extension Git Graph 3

It's probably nothing serious, but I get this when trying to install

Image

Thanks for your feedback, publisher verification setting is undergoing.

@PierreFaibrik
Copy link

IMHO, I would be a bit careful installing a non-verified extension that has only approx 100 downloads, with a logo that looks pretty much GitGraph's one and that can access my code and all my files on my machine

@deepak1556
Copy link
Collaborator

The issue has been addressed in today's insider https://code.visualstudio.com/insiders/ and will also be backported to the candidate release 1.97.2 later this week. I will lock this issue to avoid off-topic discussions

@microsoft microsoft locked as off-topic and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron regression Something that used to work is now broken
Projects
None yet
Development

No branches or pull requests