Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pug syntax highlighting #73497

Closed
msftrncs opened this issue May 9, 2019 · 3 comments
Closed

pug syntax highlighting #73497

msftrncs opened this issue May 9, 2019 · 3 comments
Assignees
Milestone

Comments

@msftrncs
Copy link

msftrncs commented May 9, 2019

There are a number of PUG syntax highlighting issues that have been closed, either labeled 'caused by extension', or moved upstream.

I think most of these are fixed in version 4.1.1 of VSCode-TextMate. VSCode is still building with version 4.0.1.

Can this be updated, please?
Thanks.

Reference:
#70535
#65983
maybe #57152

/cc: @angelul, @Tenrys, @neilsoult, @Dan503

@msftrncs
Copy link
Author

msftrncs commented May 9, 2019

I can confirm through a test build that the vscode-textmate 4.1.1 will fix #70535, and from what I can tell, all of #65983.

image

#57152 however appears to be complicated and partially related to the JavaScript grammar inclusion.

@aeschli aeschli assigned alexr00 and unassigned aeschli May 9, 2019
@alexr00
Copy link
Member

alexr00 commented May 16, 2019

I'll look into updating the version of textmate!

@alexr00 alexr00 added this to the May 2019 milestone May 21, 2019
@msftrncs
Copy link
Author

@alexandrudima seems to have gotten to this with f0ba210 and later fixture cleanup by @mjbvz with 6b081a9.

This also helps with an HTML issue, microsoft/vscode-textmate#49 and with issues I was having with PowerShell/EditorSyntax#155 and PowerShell/EditorSyntax#156.

Thanks all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants