Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try_open_file is part of WIL_ENABLE_EXCEPTIONS block #453

Open
medarkmatter6 opened this issue Jul 25, 2024 · 3 comments
Open

try_open_file is part of WIL_ENABLE_EXCEPTIONS block #453

medarkmatter6 opened this issue Jul 25, 2024 · 3 comments
Assignees
@ChrisGuzak
Labels
feature-request New feature or request

Comments

@medarkmatter6
Copy link

medarkmatter6 commented Jul 25, 2024 •
edited
Loading

filesystem.h:1130

try_open_file does not throw exceptions as it returns a file+error result. But its disabled because it's inside the ifdef WIL_ENABLE_EXCEPTIONS.

Does this still throw or is this just a bug?
@dunhor
Copy link
Member

dunhor commented Jul 25, 2024

From what I recall during PR discussion, @ChrisGuzak said that this was intentional

@dunhor dunhor added the investigate An issue that may or may not be an issue with WIL. Requires further investigation label Jul 25, 2024
@ChrisGuzak
Copy link
Member

ChrisGuzak commented Jul 25, 2024 •
edited
Loading

does not throw. it could be moved out.

@medarkmatter6
Copy link
Author

Thanks for the responses! Sorry I should have contributed my own pr for this

@dunhor dunhor added feature-request New feature or request and removed investigate An issue that may or may not be an issue with WIL. Requires further investigation labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisGuzak ChrisGuzak

Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChrisGuzak @dunhor @medarkmatter6