Rust docs broken

[kennykerr]

Just leaving this issue here as a few people have asked. There are two separate issues.

The Windows crate docs are broken due to this rustc bug.

The generated documentation hasn't been updated because cargo hangs trying to build windows-docs-rs. I seem to have hit some kind of limit, but its not clear what's wrong. rustc allocates about 5 GB and then cargo hangs inside git_refdb_backend_fs. This happens reliably. Here's a repro if you want to play along.

Running out of memory while the CPU idles is kind of sad. 😢 Here is stable/night/nightly-2021-03-16 running in parallel:

In all three cases, the hang happens here:

[kennykerr]

FYI @jyn514 and @GuillaumeGomez if you have any insights.

[kennykerr]

I tried applying a workaround (#616) that @rylev suggested for the docs.rs build issue but it now fails for a different reason:

https://docs.rs/crate/windows/0.5.0/builds/363871

[jyn514]

@kennykerr have you been able to bisect this to a nightly toolchain? Or was this caused by a change to windows-rs?

I still can't build windows-rs on linux, so I can't be much help unfortunately.

[GuillaumeGomez]

Is rustc.exe supposed to be rustdoc binary?

[kennykerr]

I still can't build windows-rs on linux, so I can't be much help unfortunately.

Fine! I'm going to get this project building on Linux. 😎

[kennykerr]

have you been able to bisect this to a nightly toolchain? Or was this caused by a change to windows-rs?

I don't know - quite a lot changed on the windows-rs side since the docs last compiled that it's hard to tell where the problem originated.

[GuillaumeGomez]

I might be able to test next week if not fixed until then.

[rylev]

The docs are still failing due to the issue posted in rust-lang/rust#82991. This affects cross compilation which is what docs-rs is doing.

I posted a workaround for this here: #522 (comment)

[kennykerr]

@jyn514 I have added basic Linux build support (#619):

https://github.com/microsoft/windows-rs/runs/2143667658

This excludes tests (for obvious reasons) but it should at least build the windows crate. Hope that helps.

[kennykerr]

I wonder if I can now remove this:

windows-rs/Cargo.toml

Lines 32 to 34 in 198621c

	[package.metadata.docs.rs]
	default-target = "x86_64-pc-windows-msvc"
	targets = ["x86_64-pc-windows-msvc"]

[jyn514]

I tried applying a workaround (#616) that rylev suggested for the docs.rs build issue but it now fails for a different reason:

On linux the workaround doesn't help, it still fails while documenting (not when building - possibly this is related to rust-lang/rust#68427):

thread 'rustc' panicked at 'Failed to get crate data for crate19', compiler/rustc_metadata/src/creader.rs:136:32

Hopefully this will be fixed when rust-lang/rust#82991 is, if not we are in deep trouble 😅

[jyn514]

Oh wait no I take it back, it happens while building too. That's a good thing, that means it doesn't need massive changes to rustdoc :)