Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VSCode Insiders - Microsoft.VSCode.Dsc #59

Open
Gijsreyn opened this issue Sep 18, 2024 · 3 comments
Open

Support VSCode Insiders - Microsoft.VSCode.Dsc #59

Gijsreyn opened this issue Sep 18, 2024 · 3 comments

Comments

@Gijsreyn
Copy link
Contributor

Description of the new feature / enhancement

With the new Microsoft.VSCode.Dsc released 4 days ago, I was curious if VSCode Insiders will also be able to be configured using this resource.

Proposed technical implementation details

No response

@denelon
Copy link
Contributor

denelon commented Sep 25, 2024

@Gijsreyn thanks for pointing this out. We'll add support for the insider release.

@Gijsreyn
Copy link
Contributor Author

@denelon Added a pull request. I had fiddled around with adding some sort of switch on the VSCodeExtension class, but noticed my class-based programming as sharp is I would have thought.

Anyway, having it as seperate class, always keeps a clear distinction between the two. I have moved away the function call to determine the path. It's called now when the methods are invoked. I included some Pester test based on the references from Microsoft.Windows.Developer module.

If I have some time left, I might also include the part for macOS/Linux.

@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Oct 6, 2024

@denelon I think this one can be closed. I hit up the PR and it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants