Replies: 19 comments 1 reply
-
cc @KevinLaMS |
Beta Was this translation helpful? Give feedback.
-
I think |
Beta Was this translation helpful? Give feedback.
-
I have to agree with @NatoBoram on this. It's also known as vscode on chocolatey. |
Beta Was this translation helpful? Give feedback.
-
It's only known as vscode on chocolatey because it's not an official package. If it were it would be consistent with the rest of the packages and the CLI. |
Beta Was this translation helpful? Give feedback.
-
It's still inherently a bad name for being so prone to conflict. For example, even |
Beta Was this translation helpful? Give feedback.
-
I don't know if "vscode is used somewhere" obliterates my argument. My argument is to align it with the cli for ux/discoverability reasons:
I brought up when I joined the team these potential conflicts with a generic name like |
Beta Was this translation helpful? Give feedback.
-
How about to support 2 monikers? |
Beta Was this translation helpful? Give feedback.
-
@felipecassiors that's the preference |
Beta Was this translation helpful? Give feedback.
-
The value "code" makes sense in the "Commands" key, but we've seen more preference for "vscode" as the value for the "AppMoniker" key. |
Beta Was this translation helpful? Give feedback.
-
@denelon the docs say
Does |
Beta Was this translation helpful? Give feedback.
-
No, because of multiple matches. Maybe we should invest in |
Beta Was this translation helpful? Give feedback.
-
@felipecassiors or @Tyriar if you think that feature would have merit, go ahead and create it in the cli repository. I would expect we might still have a collision between manifests of the released version and the stable version if the meta-data were similar between the two, but the results would be narrowed down. |
Beta Was this translation helpful? Give feedback.
-
@denelon based on this isn't not more of a preference: Additionally, the preference of the VS Code team is to use It's not clear what the concern about conflicts is, if an app as popular as VS Code comes around and wants to use "code" as well? Searching will still work, just |
Beta Was this translation helpful? Give feedback.
-
But @Tyriar, that's not how
Monikers are not unique, neither claimable, if two exist, The bottom line is there is no way to guarantee Or, as I said, what if we ask support for more than one moniker for a manifest? @denelon any opinion? |
Beta Was this translation helpful? Give feedback.
-
@denelon in this case, use |
Beta Was this translation helpful? Give feedback.
-
Ok I didn't know this, thanks.
This seems like a real shame. People want to use winget to automate their setup, but there's no way to guarantee that a command will not require manual intervention? |
Beta Was this translation helpful? Give feedback.
-
I meant by using the moniker. But you can do it by using the manifest id: winget install -e Microsoft.VisualStudioCode |
Beta Was this translation helpful? Give feedback.
-
@felipecassiors 👍 ok great, this is what I'll recommend using in the docs then. As for the moniker, supporting both code and vscode would be best as you suggested. |
Beta Was this translation helpful? Give feedback.
-
There is also a feature request accepted, that will prevent you to have to use the microsoft/winget-cli#292 - spec But until there, it is safer to use the |
Beta Was this translation helpful? Give feedback.
-
The CLI for VS Code is
code
/code-insiders
and as a result the deb/snap/rpm packages are namedcode
andcode-insiders
. The winget package should do it as well. I'd like to make this change if it sounds good.Beta Was this translation helpful? Give feedback.
All reactions