Kiwix.KiwixJS version 2.0.9.0

[Jaifroid]

• Have you signed the Contributor License Agreement?
• Have you checked that there aren't other open pull requests for the same manifest update/change?
• Have you validated your manifest locally with winget validate --manifest <path>?
• Have you tested your manifest locally with winget install --manifest <path>?
• Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

---

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

   

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @Jaifroid,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

[Jaifroid]

@ItzLevvie I rebuilt this app and signed it again, because validation was failing before. It's still failing, yet it installs fine locally (see screenshot below). I cannot find anything wrong with the package. I can only assume now that there is a problem in the winget validation pipeline. It wouldn't be the first time I've had this issue with appxbundle packages, and it has needed developer attention to resolve it. I believe the winget devs don't test regularly on appxbundles that contain HTML/JS UWP apps. Can this PR be flagged for developer attention, please?

[ItzLevvie]

Monday, 4th of July 2022 is a holiday in the United States so the WinGet engineering team will check back on Tuesday, 5th of July 2022.

cc @denelon: This pull request needs an engineer's attention.

[AmelBawa-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @Jaifroid,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

[Trenly]

2022-07-05 09:32:09.365 [CORE] Deployment operation #0: error 0x800B0110: Opening the package from location KiwixWebApp_2.0.9.0_AnyCPU.appxbundle failed.
2022-07-05 09:32:09.367 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(159)\WindowsPackageManager.dll!00007FFECACF7684: (caller: 00007FFECAC895E5) Exception(1) tid(cec) 800B0110 The certificate is not valid for the requested usage.

I get this error even when running locally

[Jaifroid]

Installing on Windows 11, standard mode (not developer), the file referenced by the manifest is this one: https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.9/KiwixWebApp_2.0.9.0_AnyCPU.appxbundle

Download it, double click it, app installer loads:

Installs correctly.

[Jaifroid]

Uninstall above install and now try using winget:

@Trenly could you kindly explain the steps necessary to reproduce the error you're seeing, because I can't see it locally in Windows 11, either with the package installer or with winget.

[Trenly]

Windows 11, either with the package installer or with winget.

Clone the repo; Open powershell; CD to the folder and run ./Tools/PRTest.ps1 64990

[Jaifroid]

I've just tested installation of the package on a friend's PC. Windows 11 Pro, not in developer mode. Her windows is Spanish language. Installs correctly, says "Kiwix JS is ready":

[Jaifroid]

But the package installs fine with winget. How can I find out what the "requested usage" is that the certificate is not valid for? Clearly it is valid for installation of the package, or winget would fail to install it.

[Trenly]

I found this related issue

I also found this image, showing how sometimes your system setup restricts the certificate -

This article on Extended Key Usage may also be helpful.

[Jaifroid]

Thank you very much @Trenly for the interesting research that may help to identify the issue as being a problem with Windows 11 keychain checking.

The thing is, no matter how much I adjust the certificate settings on my local machine, it will not change the fact that the error is manifesting in the PR validation script running on Azure, and that the error has manifested only this month when I first submitted KiwixJS 2.0.9.0 -- all the previous versions of Kiwix JS prior to July have validated fine, using the same certificate and build chain.

Having said that, the current package is built with our new org certificate (the previous one runs out end of August). New certificate, same error, only on the .appxbundle package. At the same time I (originally) submitted 2.0.9.0, I also submitted an .exe Electron package built with the same (previous) certificate, which passed with no problems.

So: a certificate is valid when submitting an .exe package, but fails when submitting an .appxbundle. But the appxbundle installs fine with winget anyway. This suggests an inconsistency in the PR Testing script to me, though I'm happy to try to test other possibilities.

[Jaifroid]

@amirms Thank you for adding a waiver for this app. @ItzLevvie Would you be able to mark this as reviewed again, as merging is blocked?

[Jaifroid]

@denelon This has passed validation, has the required review, but the bot still thinks it is blocked due to missing review...

[AmelBawa-msft]

Manually approving since bot was not triggered post "validation-completed" label
CC: @denelon