Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix.WikiMed version 2.0.9.0 #66581

Conversation

Jaifroid
Copy link
Contributor

@Jaifroid Jaifroid commented Jul 17, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 17, 2022
@ghost
Copy link

ghost commented Jul 17, 2022

Hello @Jaifroid,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 17, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 18, 2022
@Jaifroid
Copy link
Contributor Author

@AmelBawa-msft This app is running into the same issue as #64990, and I think it will need the same waiver added. This app is based on the same underlying code as Kiwix.KiwixJS, and this package is an msix/appxbundle using HTML/JS as its core language. It seems winget has issues with this type of UWP app. Please note that I have one other app of this type, Kiwix.Wikivoyage, so I will no doubt need a waiver added to that too when I next update it later this month.

Meanwhile I've test-installed this manifest in winget with no issues, and the bundle's signature tests out OK.

image

image

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 18, 2022
@JohnMcPMS
Copy link
Member

@wingetbot waivers Add Validation-Installation-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 19, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 19, 2022

Hello Jaifroid,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit 6c7ff2b into microsoft:master Jul 19, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Jaifroid
Copy link
Contributor Author

@AmelBawa-msft Thank you!

@Jaifroid Jaifroid mentioned this pull request Jul 24, 2022
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Installation-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants