Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Request Steps not guaranteed to retain insertion order #891

Closed
Ndiritu opened this issue Aug 20, 2024 · 0 comments · Fixed by #892
Closed

Batch Request Steps not guaranteed to retain insertion order #891

Ndiritu opened this issue Aug 20, 2024 · 0 comments · Fixed by #892
Assignees
Labels
type:bug A broken experience

Comments

@Ndiritu
Copy link
Contributor

Ndiritu commented Aug 20, 2024

Describe the bug

We store batch requests steps in a dictionary which doesn't guarantee insertion order when reading batch request steps.

When using dependsOn within OData Batch requests, the API expects that the dependency appears earlier in the array of requests.
Microsoft Graph fails with "Invalid dependency for request Id..."

Expected behavior

The developer dictates the order of batch request steps & that the order is retained during serialization. In case of an error, developer needs to adjust their order.

How to reproduce

Add batch request steps with different keys (UUIDs, ints etc) and test that insertion order is retained when calling GetBatchRequestContentAsync()

SDK Version

3.1.17

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
@Ndiritu Ndiritu added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Aug 20, 2024
@Ndiritu Ndiritu self-assigned this Aug 20, 2024
@Ndiritu Ndiritu removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant